Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Handling #54

Closed
5 tasks
serifine opened this issue Apr 12, 2017 · 4 comments
Closed
5 tasks

Icon Handling #54

serifine opened this issue Apr 12, 2017 · 4 comments

Comments

@serifine
Copy link
Contributor

serifine commented Apr 12, 2017

  • ux-icon component

  • SVG Based Icons

  • Material Design Icon Set

  • IOS Icon Set

  • Build process to manage multiple icon sets and build the icon-map.ts file

@serifine
Copy link
Contributor Author

Through discussions so far this should use the following:

  • Different icon sets for Material and iOS
  • Use SVG based icons

@serifine serifine removed their assignment May 2, 2017
@serifine
Copy link
Contributor Author

serifine commented Sep 1, 2017

Issue moved to aurelia/ux-components #10 via ZenHub

@serifine serifine closed this as completed Sep 1, 2017
@serifine serifine reopened this Oct 6, 2017
@serifine
Copy link
Contributor Author

I think we need to take another look at Icons soon all around. There are two points.

  1. The current way this is done, through an icon map, prevents certain aspects such as letting Webpack's tree shaking decrease the file size, mostly due to the fact that the icon set is converted to a large JSON file instead of using the native SVG files.

  2. Soon we will need to add support for IOS Icons, and I feel however this is accomplished needs to be done in such a way that it is easily extensible so that custom icon sets can be added or removed.

@bigopon
Copy link
Member

bigopon commented Jun 7, 2020

We have settled with ability to configure icon set from user app, with a default icon set provided, for now. Can have a look here

if (uxConfig.icons) {
. Close this ticket for now. If we need to iterate on this again, let's open a new ticket.

@bigopon bigopon closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants