Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting access to secured API, even if logged out #44

Open
neilyoung opened this issue Jan 11, 2016 · 2 comments
Open

Getting access to secured API, even if logged out #44

neilyoung opened this issue Jan 11, 2016 · 2 comments

Comments

@neilyoung
Copy link

After successful Login/Logout sequence I can login again by providing the correct username together with a wrong password.
@neilyoung
Copy link
Author

I think it is a matter of wrong logical operator precedence. Change line 47 in backend/user-routes.js to

if (!(user.password === req.body.password)) {

@chenkie
Copy link
Contributor

chenkie commented Feb 26, 2016

I can't seem to reproduce this--I can't log back in with the correct username but wrong password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilyoung @chenkie