Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the password policy box cuts in lock 11.18.1 #1756

Closed
Bini-Saju opened this issue Nov 26, 2019 · 6 comments · Fixed by #1758
Closed

Why does the password policy box cuts in lock 11.18.1 #1756

Bini-Saju opened this issue Nov 26, 2019 · 6 comments · Fixed by #1758

Comments

@Bini-Saju
Copy link

Hi,

I have upgraded my system to use lock version 11.18.1 from 11.17.3, But the password policy cuts as in the image:

image

Note: This issue was fixed in 11.7.3 but now it is still happening. Below is the link to the same issue.
(Why does the password policy box cuts in lock?)

@Bini-Saju Bini-Saju reopened this Nov 26, 2019
@Bini-Saju
Copy link
Author

FYI- overflow-x: auto; was removed in version 11.17.3

But following is the content in css/index.styl for version 11.18.1

.auth0-lock-content-wrapper
flex-grow: 1
flex-shrink: 1
flex-basis: auto;
-webkit-overflow-scrolling touch;
overflow-x: auto;

Hopefully removing overflow-x: auto; will fix the issue

@stevehobbsdev
Copy link
Contributor

@Bini-Saju Can you confirm if it works in 11.18.0?

@stevehobbsdev
Copy link
Contributor

@Bini-Saju Not to worry, I've found the issue. It is because of the overflow-x: auto but we need to keep that to fix a different issue with the submit button on mobile views (see the associated PR). I've put in a media query to fix it for desktop.

@stevehobbsdev
Copy link
Contributor

@Bini-Saju Also, thanks for raising this!

@Bini-Saju
Copy link
Author

Bini-Saju commented Nov 29, 2019

Hi,

FYI- I know the issue on mobile views

So password policy doesn't works on 11.18.0, tried it.

It works perfectly on 11.17.3 but the lock breaks on mobile views. So upgraded to 11.18.x works good on mobile but password policy fails.

@stevehobbsdev
Copy link
Contributor

That's fine. Initially I thought the problem only came in 11.18.1, but it was actually there in 11.18.0. So the PR should fix it fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants