From 74b8be77b0f71c85871f938f49a3ea37dc7e81e5 Mon Sep 17 00:00:00 2001 From: Louis Chan Date: Fri, 6 Sep 2024 11:40:52 +0800 Subject: [PATCH 1/2] Pin ruby version --- .github/workflows/ci.yaml | 12 ++++++++++++ .tool-versions | 3 ++- example/reactnative/Gemfile.lock | 12 +++++------- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index dda122b0..12107617 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -115,12 +115,24 @@ jobs: react_native_ios: if: ${{ github.repository == 'authgear/authgear-sdk-js' && github.ref == 'refs/heads/master' && github.event_name == 'push' }} needs: test + # When we change the runner image, the ruby version will change too. + # We need to update .tool-versions to make them the same. + # See https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md runs-on: macos-13 steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version-file: "./.tool-versions" + - uses: ruby/setup-ruby@v1 + with: + # Do not specify ruby-version so that it picks the version declared in .tool-versions + # See https://github.com/ruby/setup-ruby?tab=readme-ov-file#supported-version-syntax + # ruby-version: "Unspecified intentionally. See the above comment" + # Ideally we should turn this on + # But this flag runs bundle install and cache, which does not suit our use case here. + # See https://github.com/ruby/setup-ruby?tab=readme-ov-file#caching-bundle-install-automatically + bundler-cache: false - run: sudo xcode-select -s /Applications/Xcode_15.2.app/Contents/Developer - run: npm install -g appcenter-cli - run: npm ci diff --git a/.tool-versions b/.tool-versions index 6dd8dfbb..52fb70aa 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,4 +1,5 @@ nodejs 20.9.0 yarn 1.22.22 kubectl 1.21.8 -ruby 3.3.3 +# https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md?plain=1#L31 +ruby 3.0.7 diff --git a/example/reactnative/Gemfile.lock b/example/reactnative/Gemfile.lock index 1f250806..7eaa0714 100644 --- a/example/reactnative/Gemfile.lock +++ b/example/reactnative/Gemfile.lock @@ -56,7 +56,7 @@ GEM netrc (~> 0.11) cocoapods-try (1.2.0) colored2 (3.1.2) - concurrent-ruby (1.3.3) + concurrent-ruby (1.3.4) escape (0.0.4) ethon (0.16.0) ffi (>= 1.15.0) @@ -68,17 +68,15 @@ GEM i18n (1.14.5) concurrent-ruby (~> 1.0) json (2.7.2) - minitest (5.24.1) + minitest (5.25.1) molinillo (0.8.0) nanaimo (0.3.0) nap (1.1.0) netrc (0.11.0) nkf (0.2.0) public_suffix (4.0.7) - rexml (3.3.6) - strscan + rexml (3.3.7) ruby-macho (2.5.1) - strscan (3.1.0) typhoeus (1.4.1) ethon (>= 0.9.0) tzinfo (2.0.6) @@ -99,7 +97,7 @@ DEPENDENCIES cocoapods (~> 1.15) RUBY VERSION - ruby 3.3.3p89 + ruby 3.0.7p220 BUNDLED WITH - 2.5.11 + 2.2.33 From b185ac079ada0fb8fcad641934efbb85f84ee6be Mon Sep 17 00:00:00 2001 From: Louis Chan Date: Fri, 6 Sep 2024 11:41:11 +0800 Subject: [PATCH 2/2] Fix Podfile.lock has uncommitted changes --- example/reactnative/ios/Podfile.lock | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/example/reactnative/ios/Podfile.lock b/example/reactnative/ios/Podfile.lock index b63c38e0..bdb19c03 100644 --- a/example/reactnative/ios/Podfile.lock +++ b/example/reactnative/ios/Podfile.lock @@ -1,5 +1,5 @@ PODS: - - authgear-react-native (2.11.0-rc.0): + - authgear-react-native (2.11.0): - React-Core - boost (1.76.0) - DoubleConversion (1.1.6) @@ -13,9 +13,9 @@ PODS: - ReactCommon/turbomodule/core (= 0.72.15) - fmt (6.2.1) - glog (0.3.5) - - hermes-engine (0.72.14): - - hermes-engine/Pre-built (= 0.72.14) - - hermes-engine/Pre-built (0.72.14) + - hermes-engine (0.72.15): + - hermes-engine/Pre-built (= 0.72.15) + - hermes-engine/Pre-built (0.72.15) - libevent (2.1.12) - RCT-Folly (2021.07.22.00): - boost @@ -566,7 +566,7 @@ EXTERNAL SOURCES: :path: "../node_modules/react-native/ReactCommon/yoga" SPEC CHECKSUMS: - authgear-react-native: c3beb349a95927daa4f6a7f3f3d661fdb9cbb775 + authgear-react-native: 90d8ef725f32f9e51bd22ec9ed04ea0f18c18725 boost: 7dcd2de282d72e344012f7d6564d024930a6a440 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 FBLazyVector: 25cbffbaec517695d376ab4bc428948cd0f08088