Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid crypto.subtle is undefined #1299

Closed
pamapa opened this issue Dec 13, 2023 · 1 comment · Fixed by #1300
Closed

avoid crypto.subtle is undefined #1299

pamapa opened this issue Dec 13, 2023 · 1 comment · Fixed by #1300
Assignees
@pamapa
Milestone
3.0.0-rc.0

Comments

@pamapa
Copy link
Member

pamapa commented Dec 13, 2023 •
edited
Loading

It is better to throw an exception with a message of the reason.

See https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto:
Secure context: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers.
@pamapa pamapa added this to the 3.0.0-rc.0 milestone Dec 13, 2023
@pamapa
Copy link
Member Author

pamapa commented Dec 13, 2023

See authts/react-oidc-context#1055

pamapa added a commit that referenced this issue Dec 13, 2023
@pamapa
fix: #1299 explicitly throw an error when crypto.subtle is undefined
287a433
@pamapa pamapa mentioned this issue Dec 13, 2023
Merged
2 tasks
@pamapa pamapa self-assigned this Dec 13, 2023
@pamapa pamapa mentioned this issue Dec 14, 2023
Closed
dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this issue Apr 3, 2024
@pamapa
fix: authts#1299 explicitly throw an error when crypto.subtle is unde…
5b71340 
…fined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pamapa pamapa

Labels
None yet
Projects
None yet
Milestone
3.0.0-rc.0
Development

Successfully merging a pull request may close this issue.

explicitly throw an error when crypto.subtle is undefined authts/oidc-client-ts
1 participant
@pamapa