Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings for include and exclude argument not up-to-date #1331

Closed
mfeurer opened this issue Nov 30, 2021 · 3 comments · Fixed by #1332
Closed

Docstrings for include and exclude argument not up-to-date #1331

mfeurer opened this issue Nov 30, 2021 · 3 comments · Fixed by #1332
Labels
documentation Something to be documented

Comments

@mfeurer
Copy link
Contributor

mfeurer commented Nov 30, 2021

The docstrings for include and exclude of the AutoSklearnClassifier and AutoSklearnRegressor are not up-to-date as they do not yet address that one should pass in a dict (and no longer a list).
@eddiebergman
Copy link
Contributor

They seems to correctly specify dict? However they are not very clear so I will update them.

@eddiebergman eddiebergman added the documentation Something to be documented label Dec 1, 2021
@eddiebergman eddiebergman linked a pull request Dec 1, 2021 that will close this issue
Update docstrings of include and exclude parameters of the estimators #1332
Merged
@mfeurer
Copy link
Contributor Author

mfeurer commented Dec 2, 2021

This can be closed now that you merged #1332, right?

@eddiebergman
Copy link
Contributor

Yup, I'll close seeing as you're suggesting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Something to be documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docstrings of include and exclude parameters of the estimators automl/auto-sklearn
2 participants
@mfeurer @eddiebergman