Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAGP ignores output of Android artifacts transform tasks #1346

Open
dkostyrev opened this issue Dec 24, 2024 · 1 comment
Open

DAGP ignores output of Android artifacts transform tasks #1346

dkostyrev opened this issue Dec 24, 2024 · 1 comment
Labels
bug Something isn't working toolchain:android
Milestone

Comments

@dkostyrev
Copy link

Build scan link
Build scan

Plugin version
2.6.1

Gradle version
8.10.2

JDK version
17

(Optional) Kotlin and Kotlin Gradle Plugin (KGP) version
2.1.0

(Optional) Android Gradle Plugin (AGP) version
8.7.3

Describe the bug
The plugin ignores output of tasks that transform Android variant artifacts. This behaviour leads to an empty ABI report generated (abi-dump.txt) and incorrect implementation / api advices (dependency should be implementation).

To Reproduce
Minimal reproducer
Steps to reproduce the behavior:

  1. ./gradlew :module:abiAnalysisRelease
  2. cat module/build/reports/dependency-analysis/releaseMain/abi-dump.txt
  3. The report is empty

Expected behavior
The plugin should take into account output of tasks that transform Android variants artifacts.

Additional context
The plugin makes wrong assumption here and not taking into account JAR file here (which could be not empty with such transform task).

@autonomousapps
Copy link
Owner

Thanks for the issue and the PR! I'll take a look.

@autonomousapps autonomousapps added this to the next milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working toolchain:android
Projects
None yet
Development

No branches or pull requests

2 participants