Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args is not defined in train_across_scene.py #8

Open
onpix opened this issue Aug 24, 2023 · 3 comments
Open

args is not defined in train_across_scene.py #8

onpix opened this issue Aug 24, 2023 · 3 comments

Comments

@onpix
Copy link

onpix commented Aug 24, 2023

as titled, train_across_scene.py:L212 is:

if args.render_train:
    ...

But args is not defined.

@apchenstu
Copy link
Collaborator

Ah, thank you! Yeah, it should be "cfg. render_train:", will fix it

@onpix
Copy link
Author

onpix commented Aug 28, 2023

Thanks for your response. But it seems that the L215 has an error as well:

PSNRs_test = evaluation(train_dataset,model, args, renderer, f'{logfolder}/imgs_train_all/',
                                N_vis=-1, N_samples=-1, white_bg = white_bg, ndc_ray=ndc_ray,device=device)

I guess args should not be here, and renderer is also not defined._

@apchenstu
Copy link
Collaborator

Ah okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants