Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include locally cached pieces in the list of provided pieces #1133

Closed
nazar-pc opened this issue Feb 1, 2023 · 1 comment · Fixed by #1138
Closed

Include locally cached pieces in the list of provided pieces #1133

nazar-pc opened this issue Feb 1, 2023 · 1 comment · Fixed by #1138
Assignees
@nazar-pc
Labels
farmer Farming library/app improvement it is already working, but can be better networking Subspace networking (DSN) node Node (service library/node app)
Milestone
Gemini 3

Comments

@nazar-pc
Copy link
Member

nazar-pc commented Feb 1, 2023

The way we have things implemented right now is suboptimal and should conform to the following:

  • provider storage has no persistent records related to the node itself because it can all be derived, typically from in-memory information
  • fn providers and fn provided() takes local caches into account (farmer implementation only takes plots into account right now)

This applies to both node and farmer.
@nazar-pc nazar-pc added farmer Farming library/app improvement it is already working, but can be better networking Subspace networking (DSN) node Node (service library/node app) labels Feb 1, 2023
@nazar-pc nazar-pc added this to the Gemini 3 milestone Feb 1, 2023
@nazar-pc nazar-pc mentioned this issue Feb 1, 2023
Merged
1 task
@nazar-pc
Copy link
Member Author

nazar-pc commented Feb 1, 2023

Working on this

@nazar-pc nazar-pc moved this from Todo to Blocked in Subspace core (node, farmer, etc.) Feb 1, 2023
@nazar-pc nazar-pc moved this from Blocked to In Progress in Subspace core (node, farmer, etc.) Feb 1, 2023
@nazar-pc nazar-pc mentioned this issue Feb 2, 2023
Merged
1 task
@nazar-pc nazar-pc moved this from In Progress to Under Review in Subspace core (node, farmer, etc.) Feb 2, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Closed in Subspace core (node, farmer, etc.) Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nazar-pc nazar-pc

Labels
farmer Farming library/app improvement it is already working, but can be better networking Subspace networking (DSN) node Node (service library/node app)
Projects
Subspace core (node, farmer, etc.)
Archived in project
Milestone
Gemini 3
Development

Successfully merging a pull request may close this issue.

Use cache for providers autonomys/subspace
2 participants
@nazar-pc @shamil-gadelshin