Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRITON_MYSQL_CONSUL vs CONSUL as environment variable in triton-mysql.py #11

Closed
jasondewitt opened this issue Apr 13, 2016 · 3 comments
Closed
Labels

Comments

@jasondewitt
Copy link
Contributor

Should the default environment varible for consul be TRITON_MYSQL_CONSUL here?
https://github.com/autopilotpattern/mysql/blob/master/bin/triton-mysql.py#L35

Seems like using simply 'CONSUL' here will make it easier to line up with other services in a single compose project, especially when running on Triton using CNS.

@misterbisson
Copy link
Contributor

That's a good question that goes with #10 and further cleanup proposed by #12.

@tgross might be able to answer whether or not he had a special reason for the var name, or if he was namespacing it out of habit.

@tgross
Copy link
Contributor

tgross commented Apr 14, 2016

Yeah, I don't think there was any particular name and I agree that having it just be CONSUL would be better.

@misterbisson
Copy link
Contributor

Fixed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants