golang: limit size of allocations

Don't allow to make allocations large than 64MB. Signed-off-by: Andrei Vagin <[email protected]>
avagin · Nov 17, 2023 · f3b882c · f3b882c
1 parent 2bc70b2
commit f3b882c
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/WORKSPACE b/WORKSPACE
@@ -95,7 +95,7 @@ go_download_sdk(
     # time on our continuous integration.
     patch = "//tools:go_types_memoize.patch",
     patch_strip = 2,
-    version = "1.21.1",
+    version = "1.21.3",
 )
 
 gazelle_dependencies()

diff --git a/tools/go_allocation_limit.patch b/tools/go_allocation_limit.patch
@@ -0,0 +1,14 @@
+diff --git a/src/runtime/malloc.go b/src/runtime/malloc.go
+index 44479cc2be..adcee90992 100644
+--- a/src/runtime/malloc.go
++++ b/src/runtime/malloc.go
+@@ -946,6 +946,9 @@ func (c *mcache) nextFree(spc spanClass) (v gclinkptr, s *mspan, shouldhelpgc bo
+ // Small objects are allocated from the per-P cache's free lists.
+ // Large objects (> 32 kB) are allocated straight from the heap.
+ func mallocgc(size uintptr, typ *_type, needzero bool) unsafe.Pointer {
++	if size > (64 << 20) {
++		throw("large allocation")
++	}
+ 	if gcphase == _GCmarktermination {
+ 		throw("mallocgc called with gcphase == _GCmarktermination")
+ 	}
diff --git a/tools/go_types_memoize.patch b/tools/go_types_memoize.patch
@@ -1,3 +1,17 @@
+diff --git a/src/runtime/malloc.go b/src/runtime/malloc.go
+index 44479cc2be..adcee90992 100644
+--- a/go/src/runtime/malloc.go
++++ b/go/src/runtime/malloc.go
+@@ -946,6 +946,9 @@ func (c *mcache) nextFree(spc spanClass) (v gclinkptr, s *mspan, shouldhelpgc bo
+ // Small objects are allocated from the per-P cache's free lists.
+ // Large objects (> 32 kB) are allocated straight from the heap.
+ func mallocgc(size uintptr, typ *_type, needzero bool) unsafe.Pointer {
++	if size > (64 << 20) {
++		throw("large allocation")
++	}
+ 	if gcphase == _GCmarktermination {
+ 		throw("mallocgc called with gcphase == _GCmarktermination")
+ 	}
 diff --git a/go/src/go/types/scope.go b/src/go/types/scope.go
 index 010727eb72..0f134b872e 100644
 --- a/go/src/go/types/scope.go