-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-javax releases are not reproducible #757
Comments
@rbygrave do you do anything extra for javax releases? |
That's not great. That'll come from the difference between linux vs macOS wrt
Hmmm, not sure why per se but noting that there are not 2 timestamps meaning that in git the timestamp there is from the jakarta release and not the javax one. So it isn't clear to me how that would work in that to me it seems we'd need 2 timestamps with one for Jakarta and one for Javax ... so not sure.
We also need to change the actual maven pom versions |
Unless you are asking to have a separate git tag for the javax release? ... is that what you are asking? |
IMHO, we don't need a separate Git tag for javax release: using the non javax tag is perfect, as AFAIK |
see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/io/avaje/inject/README.md
non
-javax
releases are perfectly checked as reproducible: build recipe is quite simple and classical, like jvm-repo-rebuild/reproducible-central#1361for
-javax
releases, the timestamp does not correspond as what is in Git, and there are additional.java-e
files in-sources.jar
that come from nowhere in Git, like jvm-repo-rebuild/reproducible-central#1359I don't know what is the release process for
-javax
builds in Maven Central, but it's not what I'd expect = simply start from Git tag, apply./jakarta-to-javax.sh
and rebuild to deploy: is there a deliberate reason? And in that case, how to generate the.java-e
files?The text was updated successfully, but these errors were encountered: