Consolidate mini and verbose reporters

[novemberborn]

Currently we have two different reporter implementations. Code is duplicated across them which leads to various bugs. I once tried to consolidate them but that work stalled.

The idea is that we would have only one reporter. By default it provides minimal output. We show a spinner and the status of the last test, so you get a sense of activity, and once an entire test file completes do we print failures. In verbose mode, we'd print the results of all tests & hooks, including logs. Various counts for passing and failing tests are always shown at the end of the output.

If a TTY is not available, we wouldn't print a spinner and only write the appropriate output for a test file once it completes.

We'd use ink to construct the output.

[novemberborn]

@yovasx2 you've privately expressed interest in working on this. If you comment on this issue I can assign it to you within the GitHub interface.

[kridency]

You could assign this task on me. But I have to warn you that this is my first time on github, so it will take some time to get familiar with.

[novemberborn]

@biofreak that's great, but @yovasx2 is working on this at the moment.

[yovasx2]

Sure

[pcdevil]

as of #2458 I expressed my interest to work with this and I'd take it!

[novemberborn]

@pcdevil did you manage to take a stab at this? I think @Michael55555 is interested in working on this as well.

[pcdevil]

Hello @novemberborn,

Sorry, I only did small improvements locally, started to outsource the identical part of VerboseReporter.consumeStateChange() into a new BaseReporter class.

Unfortunately I didn't have much time in the last two weeks as anticipated. I can hand it over that code to @Michael55555, no harm on my part if he wants to take it over!

[novemberborn]

Thanks for the update @pcdevil.

FWIW I don't think we need any base class. We can envision a single reporter, which in verbose mode… reports more!

@Michael55555 what do you think?

[m5x5]

Moving the functionality from minimal to verbose would possibly be the best way to do it.
Once we did that, we can give the new reporter class a more descriptive name.

[novemberborn]

I'm not sure if modifying the current code is going to cut it.

[m5x5]

Ok, I see. I think creating a base class would be great to avoid writing code twice. Some functions in the tap and the verbose reporter seem to be nearly the same.

[novemberborn]

I don't want us to expend any energy on the TAP reporter. Longer term we'll move it out of this repository. The duplication is fine for the time being.

[m5x5]

Alright, I see. I just created a base-reporter.js, which holds bot mini.js and verbose.js.

[m5x5]

@novemberborn I opened a pull request referencing this issue already, I'd be happy if you review the changes 😄. #2488

[novemberborn]

I've split off #2500 & #2501.