Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play Icon Misaligned #5927

Closed
1 task
joncameron opened this issue Jul 12, 2024 · 2 comments
Closed
1 task

Play Icon Misaligned #5927

joncameron opened this issue Jul 12, 2024 · 2 comments
Assignees
@Dananji

Comments

@joncameron
Copy link
Contributor

joncameron commented Jul 12, 2024 •
edited
Loading

Description

The play icon that appears when the media isn't playing is out of alignment with it's circle container—it should be centered.

Screenshot

Screenshot 2024-07-12 at 12.00.31 PM.png

Done Looks Like

  • Triangular play icon is centered within the containing circle
@Dananji Dananji self-assigned this Jul 17, 2024
@Dananji Dananji mentioned this issue Jul 17, 2024
Merged
@Dananji
Copy link
Contributor

Dananji commented Jul 17, 2024

The related change was made in Ramp code. And the change applies for both play icon and volume slider thumb's vertical alignment (samvera-labs/ramp#559).

Once it is brought into Avalon, appearance for both play icon and volume slider thumb in item view page, playlists, and embeds needs to re-tested.

@Dananji Dananji mentioned this issue Jul 17, 2024
Merged
@joncameron
Copy link
Contributor Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dananji Dananji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dananji @joncameron