Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide attachment button on :trix fields for new/create. #2389

Closed
MrJoy opened this issue Jan 19, 2024 · 2 comments · Fixed by #2429
Closed

Hide attachment button on :trix fields for new/create. #2389

MrJoy opened this issue Jan 19, 2024 · 2 comments · Fixed by #2429
Labels
Enhancement Not necessarily a feature, but something has improved Help wanted We could use some help with this

Comments

@MrJoy
Copy link
Contributor

MrJoy commented Jan 19, 2024

Feature

The Trix editor doesn't allow adding attachments until a record has been saved. Having the attachment button visible just sets a user expectation that isn't accurate.

Current workarounds

Screenshots or screen recordings

Additional context

@MrJoy
Copy link
Contributor Author

MrJoy commented Jan 19, 2024

... related: If attachment_key isn't set, attachments_disabled should probably be true by default. Alternatively, if attachments_disabled is false, and attachment_key isn't set, it might be worth surfacing to the developer that the field is not configured correctly.

@adrianthedev
Copy link
Collaborator

Good spot! We'll take a PR for this.

@adrianthedev adrianthedev added Enhancement Not necessarily a feature, but something has improved Help wanted We could use some help with this labels Jan 22, 2024
@github-project-automation github-project-automation bot moved this to Done in Issues Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved Help wanted We could use some help with this
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants