Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return valid attributes for html options #2397

Merged
merged 3 commits into from
Jan 22, 2024
Merged

fix: return valid attributes for html options #2397

merged 3 commits into from
Jan 22, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #2390

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Jan 22, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 22, 2024 •
edited
Loading

Code Climate has analyzed commit 250d2c4 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 7a16dd7 into main Jan 22, 2024
18 of 22 checks passed
@adrianthedev adrianthedev deleted the fix/html-data-nil branch January 22, 2024 16:14
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
1 participant
@adrianthedev