chore: register stimulus controllers from plugins #3608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to auto-register StimulusJS controllers from plugins.
See how https://github.com/avo-hq/marksmith is achieving that.
This PR:
Avo.asset_manager.register_stimulus_controller "marksmith", "MarksmithController"
window.Avo
objectlate-registration
file which picks them up and registers them in the current applicationController
class is being assigned to thewindow
object so it can be used by the plugin controllers in order to not bundle it with the plugin resulting in duplicated code (StimulusJS)Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.