Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle multi-word class names in array resource adapter #3684

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes part of #3680

The ArrayResource was incorrectly using name instead of class_name to define the backbone class. This caused errors when working with multi-word resources such as Avo::Resources::DisplayName.

This fix ensures that class_name is used correctly.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Feb 21, 2025
@Paul-Bob Paul-Bob self-assigned this Feb 21, 2025
Copy link

codeclimate bot commented Feb 21, 2025

Code Climate has analyzed commit 7ee642a and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title fix: array resource adapter fix: correctly handle multi-word class names in array resource adapter Feb 21, 2025
@Paul-Bob Paul-Bob merged commit 9f81a6c into main Feb 21, 2025
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/array_resource branch February 21, 2025 14:38
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants