Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(predictions): Use English locale for date/time #2491

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Jun 26, 2023

  • PR title and description conform to Pull Request guidelines.

Use English Locale instead of default. Tested that this fixes the websocket error when device language is set to Arabic. Swift version is here.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing requested a review from a team as a code owner June 26, 2023 20:29
tylerjroach
tylerjroach previously approved these changes Jun 27, 2023
tylerjroach
tylerjroach previously approved these changes Jun 27, 2023
mattcreaser
mattcreaser previously approved these changes Jun 27, 2023
@eeatonaws eeatonaws dismissed stale reviews from mattcreaser and tylerjroach via 0371515 June 27, 2023 13:06
@eeatonaws eeatonaws merged commit 897a1b2 into main Jun 27, 2023
@eeatonaws eeatonaws deleted the liveness-locale-fix branch June 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants