Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix for adding missing parameter for resolving device SRP #2508

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

gpanshu
Copy link
Contributor

@gpanshu gpanshu commented Jul 11, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: 2504

Description of changes: Currently the respondToAuth api for device SRP does not include the secret hash param and this PR adds that.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gpanshu gpanshu requested a review from a team as a code owner July 11, 2023 17:18
@gpanshu gpanshu enabled auto-merge (squash) July 12, 2023 20:27
@gpanshu gpanshu merged commit c69588e into main Jul 12, 2023
@gpanshu gpanshu deleted the fix-deviceSRP branch July 12, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotAuthorizedException: Client xxxxx is configured with secret but SECRET_HASH was not received
3 participants