Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(predictions): send close frame when error occurs #2519

Merged
merged 5 commits into from
Jul 20, 2023
Merged

fix(predictions): send close frame when error occurs #2519

merged 5 commits into from
Jul 20, 2023

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Jul 18, 2023

  • PR title and description conform to Pull Request guidelines.

When error occurs (ex: timeout on face oval match) close the stream gracefully so that Rekognition service knows to stop the session.

How did you test these changes?
Ran on device, checked that resulting session closed successfully.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing added the predictions Related to the Predictions category/plugins label Jul 18, 2023
@tjleing tjleing self-assigned this Jul 18, 2023
@tjleing tjleing requested a review from a team as a code owner July 18, 2023 20:23
mattcreaser
mattcreaser previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mattcreaser mattcreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test?

@gpanshu gpanshu self-requested a review July 19, 2023 19:07
gpanshu
gpanshu previously approved these changes Jul 19, 2023
View reviewed changes
@tjleing tjleing dismissed stale reviews from gpanshu and mattcreaser via df88503 July 19, 2023 21:29
@tjleing tjleing enabled auto-merge (squash) July 19, 2023 21:54
@tjleing tjleing requested review from mattcreaser and gpanshu July 19, 2023 23:04
@tjleing tjleing merged commit b9dbd25 into main Jul 20, 2023
@tjleing tjleing deleted the liveness-send-close-frame branch July 20, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpanshu gpanshu gpanshu approved these changes

@mattcreaser mattcreaser mattcreaser approved these changes

Assignees

@tjleing tjleing

Labels
predictions Related to the Predictions category/plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjleing @mattcreaser @gpanshu @sdhuka