fix(auth): Fix for sending session expired when an invalid grant exception is received #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tjleing
previously approved these changes
Jul 21, 2023
gpanshu
force-pushed
the
fix-sessionexpired-when-invalidgrant
branch
from
198ceb7 to
bf1ad63
Compare
gpanshu
force-pushed
the
fix-sessionexpired-when-invalidgrant
branch
from
bf1ad63 to
89c88dd
Compare
…s to get a success with isSignedIn as false
sdhuka
approved these changes
Jul 25, 2023
mattcreaser
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2481
Description of changes: When we get an invalid_grant exception back from cognito we do not send the session expired hub event but we should as that means your session is no longer valid. This PR fixes that. Cognito also sends the error_description which was not captured
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.