fix(datastore/flutter): Custom type list serde #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: aws-amplify/amplify-flutter#3472, aws-amplify/amplify-flutter#3482 The issue of ser/deseralizing custom types was partially fixed by #2350. However, once this was released, customers quickly noticed new issues. The prior fix did not handle arrays of custom types which this PR addresses.
dnys1
force-pushed
the
fix/datastore/flutter-custom-model-list
branch
from
bb5d06e to
1e5b6c3
Compare
tylerjroach
approved these changes
Aug 4, 2023
gpanshu
approved these changes
Aug 8, 2023
14 tasks
dnys1
pushed a commit
to aws-amplify/amplify-flutter
that referenced
this pull request
Aug 11, 2023
Incorporates aws-amplify/amplify-android#2545 to fix custom list serialization and deserialization on Android.
dnys1
added a commit
to aws-amplify/amplify-flutter
that referenced
this pull request
Aug 14, 2023
Incorporates aws-amplify/amplify-android#2545 to fix custom list serialization and deserialization on Android.
dnys1
added a commit
to aws-amplify/amplify-flutter
that referenced
this pull request
Aug 14, 2023
Incorporates aws-amplify/amplify-android#2545 to fix custom list serialization and deserialization on Android.
dnys1
added a commit
to aws-amplify/amplify-flutter
that referenced
this pull request
Aug 14, 2023
Incorporates aws-amplify/amplify-android#2545 to fix custom list serialization and deserialization on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aws-amplify/amplify-flutter#3472, aws-amplify/amplify-flutter#3482
The issue of ser/deseralizing custom types was partially fixed by #2350. However, once this was released, customers quickly noticed new issues. The prior fix did not handle arrays of custom types which this PR addresses.
This PR adds verbose logging alongside the fix. The actual code change/fix is here: https://github.com/aws-amplify/amplify-android/pull/2545/files#diff-2add64014d3bad6c0614a14c3bf6f5b84660fdf5393008933484082fb4cd47ddR143