fix(flutter/datastore): Nullable custom type arrays #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws-amplify/amplify-flutter#3575. When a custom type array is not required and `null` is returned from AppSync, deserialization will fail since `getAsJsonArray` will throw for `null` values. This resolves the issue by checking if a field is `null` before attempting deserialization.
dnys1
force-pushed
the
fix/datastore/nullable-custom-arrays
branch
from
61273fa to
cd0025e
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2565 +/- ##
==========================================
+ Coverage 41.43% 41.44% +0.01%
==========================================
Files 874 874
Lines 27644 27648 +4
Branches 3883 3884 +1
==========================================
+ Hits 11455 11460 +5
- Misses 14960 14961 +1
+ Partials 1229 1227 -2 |
tylerjroach
approved these changes
Aug 18, 2023
gpanshu
approved these changes
Aug 21, 2023
fjnoyp
approved these changes
Aug 21, 2023
Equartey
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-amplify/amplify-flutter#3575
Description of changes:
When a custom type array is not required and
nullis returned from AppSync, deserialization will fail sincegetAsJsonArraywill throw fornullvalues.This resolves the issue by checking if a field is
nullbefore attempting deserialization.How did you test these changes?
Added test case for
nullcustom type array.Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.