feat: usage flow logging for interactive and non-interactive cli commands #10288
Conversation
sachscode
requested review from
a team,
marcvberg,
phani-srikar,
sundersc and
alharris-at
as code owners
|
This pull request introduces 5 alerts when merging b5e475d into 0909769 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Overall looks good. Left some small comments.
My main concern is I'm not sure that the flowData object should be accessed directly but rather the usageData object has an instance of a flowData and has some methods that proxy to the flowData object. Do you think an approach like that would be feasible? Did you have a specific reason for exposing the flowData object directly?
packages/amplify-cli/src/domain/amplify-usageData/NoUsageData.ts
Outdated
Show resolved
Hide resolved
|
|
||
| /** |
There was a problem hiding this comment.
nit: remove empty block or add contents
|
This pull request introduces 5 alerts when merging a772eb9 into 9a13376 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging f3161a2 into 9a13376 - view on LGTM.com new alerts:
|
jhockett
changed the title
sachscode
force-pushed
the
feat/cliflow
branch
3 times, most recently
from
dc604b7 to
56a7521
Compare
…shHeadlessFlow from prompter
|
This pull request introduces 3 alerts when merging 67750f7 into 2af11f4 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging e2b2b12 into 2af11f4 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 2b5f5e3 into 971d517 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging e6da634 into 08fb69f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 7ad2920 into 08fb69f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 79f5014 into 08fb69f - view on LGTM.com new alerts:
|
| if ( isInteractiveShell ) { | ||
| if (this.flowData && input ) { |
There was a problem hiding this comment.
nit: can combine into one condition
Description of changes
note: Only the interactive flows which use the amplify-prompter library will be journaled . Other flows will be ported to use the prompter library.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.