fix: block init if amplify app creation fails #10839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #10839 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 673 673
Lines 33274 33275 +1
Branches 6724 6721 -3
=======================================
+ Hits 15782 15784 +2
Misses 15803 15803
+ Partials 1689 1688 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
akshbhu
reviewed
Aug 3, 2022
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Outdated
Show resolved
Hide resolved
danielleadams
previously approved these changes
Aug 11, 2022
danielleadams
added
the
semver-major
edwardfoyle
force-pushed
the
app-limit-init-block
branch
from
2e4935b to
8ae1f65
Compare
edwardfoyle
force-pushed
the
app-limit-init-block
branch
from
8ae1f65 to
9612c67
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Fixed
Show fixed
Hide fixed
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Fixed
Show fixed
Hide fixed
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Fixed
Show fixed
Hide fixed
sobolk
reviewed
Feb 6, 2023
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Outdated
Show resolved
Hide resolved
sobolk
reviewed
Feb 6, 2023
packages/amplify-provider-awscloudformation/src/amplify-service-manager.js
Outdated
Show resolved
Hide resolved
sobolk
previously approved these changes
Feb 7, 2023
|
Could you split TS conversion into separate PR and get this also to |
2 tasks
sobolk
approved these changes
Feb 8, 2023
jhockett
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Blocks
amplify initif the Amplify App service limit has been reached. This prevents downstream errors and weird behavior where an Amplify App is expected to exist.Issue #, if available
Fixes #10838
Description of how you validated changes
Tested locally, added unit test, E2E running here: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/foyleef/app-limit-init-block
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.