Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates to error handler print format #11311

Merged
merged 4 commits into from
Nov 3, 2022
Merged

fix: updates to error handler print format #11311

merged 4 commits into from
Nov 3, 2022

Conversation

pavellazar
Copy link
Contributor

@pavellazar pavellazar commented Nov 2, 2022 •
edited
Loading

Description of changes

  • prints the deepest amplify exception only
  • on debug prints third party exception
  • prints session identifier on error

Description of how you validated changes

  • manual changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pavellazar pavellazar requested a review from a team as a code owner November 2, 2022 20:28
awsluja
awsluja previously approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@awsluja awsluja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; can you run e2e?

edwardfoyle
edwardfoyle previously approved these changes Nov 2, 2022
View reviewed changes
@pavellazar pavellazar merged commit 0ac69bb into aws-amplify:dev Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolk sobolk sobolk approved these changes

@jhockett jhockett jhockett approved these changes

@awsluja awsluja awsluja left review comments

@edwardfoyle edwardfoyle edwardfoyle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavellazar @jhockett @sobolk @edwardfoyle @awsluja