fix: removes preparepp() cdkV1 shim layer #11313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
For Context :
We removed the prepareApp implementation exported in
cdk V1
and replaced with ShimImplementation : https://github.com/aws-amplify/amplify-cli/blob/cdkv2/packages/amplify-category-geo/src/service-utils/prepare-app.ts required to generate samecfn
.The fix is inspired by https://github.com/aws/aws-cdk/blob/bd056d1d38a2d3f43efe4f857c4d38b30fb9b681/packages/%40aws-cdk/assertions/lib/template.ts#L298-L310 .
This performs deep evaluation of the stack and fills missing
dependsOn
Custom lambda resources.There are two changes in PR
root.synth()
which generates full cloud assembly with dependencies. Similar behaviour is not achieved by_.toCloudformation()
w/oprepareApp()
.root.synth()
in cdkV2 usesdefaultStackSynthesizer
by default which was creating default cfn parameters for bootstartping cdk project. This is changed to previous behaviour of usinglagacyStacksyntheiser
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.