fix: dotnet lambda templates compilation issues #11562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
commented
Dec 8, 2022
packages/amplify-dotnet-function-template-provider/src/utils/dynamoDBWalkthrough.ts
Outdated
Show resolved
Hide resolved
sobolk
commented
Dec 8, 2022
sobolk
commented
Dec 8, 2022
| }); // will throw if successString is not in output | ||
| }); | ||
|
|
||
| it('add dotnet crud function and invoke in the cloud', async () => { |
There was a problem hiding this comment.
crud template is not able to use amplify mock function. it requires ddb table reference at runtime. Hence this test pushes and calls real lambda.
sobolk
commented
Dec 8, 2022
| expect(JSON.parse(response.Payload.toString())).toEqual(helloWorldSuccessObj); | ||
| }); | ||
|
|
||
| it('add dotnet serverless function and mock locally', async () => { |
There was a problem hiding this comment.
new coverage is base on mock as it compiles and runs dotnet code locally. this is best effort, some templates like crud don't work locally.
sobolk
commented
Dec 8, 2022
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "body": null, | |||
| "resource": "<%= props.functionTemplate.parameters.path %>/{proxy+}", | |||
| "path": "<%= props.functionTemplate.parameters.path %>/", | |||
| "path": "<%= props.functionTemplate.parameters.path %>/<%= props.functionTemplate.parameters.database.tableDefinition.partitionKeyName %>:foo", | |||
There was a problem hiding this comment.
while we don't use this event in test I was playing a bit with this in aws console to invoke resulting lambda.
previous version was leading to error response asking for missing path parameter - this change fixes this.
sobolk
changed the title
jhockett
previously approved these changes
Dec 8, 2022
packages/amplify-dotnet-function-template-provider/src/utils/dynamoDBWalkthrough.ts
Outdated
Show resolved
Hide resolved
jhockett
approved these changes
Dec 8, 2022
pavellazar
approved these changes
Dec 8, 2022
sobolk
added a commit
that referenced
this pull request
Dec 8, 2022
* fix: fix dotnet lambda templates * fix: fix naming * fix: split function_3 * fix: cover triggers * fix: fix tests * fix: fix tests * fix: add kinesis test * chore: pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes existing dotnet templates and makes sure that they work (i.e. compile and return something).
Current samples (except Hello World) don't compile due to dependency conflicts.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.