Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add command and minor corrections #12037

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

ykethan
Copy link
Member

@ykethan ykethan commented Feb 17, 2023

Description of changes

added amplify build command info to help command.
corrected function build and remove info

Issue #, if available

Description of how you validated changes

setup amplify dev, build and test in a project
image

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@ykethan ykethan requested a review from a team as a code owner February 17, 2023 22:36
goldbez
goldbez previously approved these changes Feb 17, 2023
Copy link
Member

@goldbez goldbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov-commenter
Copy link

Codecov Report

Merging #12037 (5bfdc6d) into dev (984c0f8) will decrease coverage by 3.48%.
The diff coverage is 53.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev   #12037      +/-   ##
==========================================
- Coverage   49.45%   45.98%   -3.48%     
==========================================
  Files         692      820     +128     
  Lines       33424    37687    +4263     
  Branches     6840     7706     +866     
==========================================
+ Hits        16529    17329     +800     
- Misses      15370    18676    +3306     
- Partials     1525     1682     +157     
Impacted Files Coverage Δ
...sync-simulator/src/data-loader/opensearch/index.ts 45.45% <0.00%> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...sync-simulator/src/velocity/util/dynamodb-utils.ts 6.55% <0.00%> (ø)
...y-appsync-simulator/src/velocity/util/map-utils.ts 10.00% <ø> (ø)
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...ync-simulator/src/velocity/util/transform/index.ts 21.05% <0.00%> (ø)
...appsync-simulator/src/velocity/value-mapper/map.ts 86.88% <ø> (ø)
...ackages/amplify-category-auth/src/commands/auth.ts 0.00% <0.00%> (ø)
...es/amplify-category-auth/src/commands/auth/help.ts 0.00% <0.00%> (ø)
.../amplify-category-auth/src/commands/auth/import.ts 0.00% <0.00%> (ø)
... and 527 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

josefaidt
josefaidt previously approved these changes Feb 20, 2023
@ykethan ykethan dismissed stale reviews from josefaidt and goldbez via a2b05d3 February 21, 2023 17:52
@jhockett jhockett merged commit aabb8be into aws-amplify:dev Feb 21, 2023
@ykethan ykethan deleted the update-command-info branch February 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants