fix: stops cdk v1 warning for non cdk custom resource #12241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
previously approved these changes
Mar 15, 2023
| @@ -65,7 +65,7 @@ const getOverridesWarning = (resourcesToBuild: IAmplifyResource[], dependencyToS | |||
| const getCustomResourcesWarning = (resourcesToBuild: IAmplifyResource[], dependencyToSearch: string): AmplifyWarning | undefined => { | |||
| let customResourcesWarningObject; | |||
| const customResourceImpactedFiles = []; | |||
| const customCategoryResources = resourcesToBuild.filter((resource) => resource.category === AmplifyCategories.CUSTOM); | |||
| const customCategoryResources = resourcesToBuild.filter((resource) => resource.category === AmplifyCategories.CUSTOM && resource.service !== 'customCloudformation'); | |||
There was a problem hiding this comment.
consider extracting second part of condition to !isCFNBasedCustomeResource(resource) for future readers.
Comment on lines
42
to
46
| await addCFNCustomResource(projRoot, { name: cfnResourceNameWithV10, promptForCategorySelection: false }); | ||
| const srcCFNCustomResourceFilePath = path.join(__dirname, '..', '..', '..', 'custom-resources', 'custom-cfn-stack.json'); | ||
| // adding a resource to custom cfn stack | ||
| const destCFNCustomResourceFilePath = path.join(projRoot, 'amplify', 'backend', 'custom', cfnResourceNameWithV10,`${cfnResourceNameWithV10}-cloudformation-template.json`); | ||
| fs.copyFileSync(srcCFNCustomResourceFilePath, destCFNCustomResourceFilePath); |
There was a problem hiding this comment.
consider adding one non-migration test that would spin up only CFN based custom without any CDK.
sobolk
approved these changes
Mar 15, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #12241 +/- ##
==========================================
- Coverage 49.45% 47.15% -2.30%
==========================================
Files 692 836 +144
Lines 33424 38038 +4614
Branches 6840 7715 +875
==========================================
+ Hits 16529 17937 +1408
- Misses 15370 18465 +3095
- Partials 1525 1636 +111
... and 456 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lazpavel
approved these changes
Mar 16, 2023
sobolk
pushed a commit
to sobolk/amplify-cli
that referenced
this pull request
Mar 16, 2023
) * fix: stops cdk warning for non cdk custom resource * fix: added unit test --------- Co-authored-by: Akshay Upadhyay <[email protected]>
sobolk
added a commit
that referenced
this pull request
Mar 16, 2023
* fix: stops cdk warning for non cdk custom resource * fix: added unit test --------- Co-authored-by: akshbhu <[email protected]> Co-authored-by: Akshay Upadhyay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.