fix: do not store windows specific package manager extension #13047
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #13047 +/- ##
===========================================
+ Coverage 0.00% 48.45% +48.45%
===========================================
Files 1296 842 -454
Lines 149743 38038 -111705
Branches 1296 7788 +6492
===========================================
+ Hits 0 18432 +18432
+ Misses 148447 18016 -130431
- Partials 1296 1590 +294
... and 1243 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -40,14 +40,14 @@ class NpmPackageManager implements PackageManager { | |||
| class YarnPackageManager implements PackageManager { | |||
| readonly packageManager: PackageManagerType = 'yarn'; | |||
| readonly displayValue = 'Yarn'; | |||
| readonly executable = isWindows ? 'yarn.cmd' : 'yarn'; | |||
| readonly executable = 'yarn'; // Windows does not require `.cmd` extension to invoke yarn | |||
There was a problem hiding this comment.
nit: do we need that comment at all? 😂
There was a problem hiding this comment.
Yes, it's required to implement the PackageManager interface: https://github.com/aws-amplify/amplify-cli/blob/dev/packages/amplify-cli-core/src/utils/packageManager.ts#L21
Description of changes
Remove the
.cmdextension fromyarnfor Windows since it's not needed and causes issues with teams working across multiple OS'sIssue #, if available
#13043
#13001
Description of how you validated changes
https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing:1306a0c1-9604-4ed5-906c-96f456d5bf3a?region=us-east-1#
I'm relying on this test for verification.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.