fix: amplify app version regex #13050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
commented
Aug 2, 2023
| @@ -1469,7 +1469,9 @@ commands: | |||
| source $BASH_ENV | |||
| - run: | |||
| name: Confirm Amplify CLI is installed and available in PATH | |||
| command: amplify version | |||
| command: | | |||
| which amplify | |||
There was a problem hiding this comment.
Added this to confirm that amplify resolves right path. I find it useful for troubleshooting, hence leaving it.
awsluja
previously approved these changes
Aug 2, 2023
edwardfoyle
previously approved these changes
Aug 2, 2023
jhockett
suggested changes
Aug 2, 2023
Co-authored-by: John Hockett <[email protected]>
jhockett
approved these changes
Aug 2, 2023
awsluja
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix amplify app regex to capture
<major>.<minor>.<fix>prefix correctly.Previous version was incorrectly processing tag/rc versions.
Issue #, if available
Description of how you validated changes
CB:
https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing%3Af6bdb9ac-5a93-4898-86d1-a01f1907a4b5?region=us-east-1
CCI:
https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e%2Fsobkamil%2Ffix-modelgen-test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.