test: remove extra hash #13071
Merged
test: remove extra hash #13071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhockett
approved these changes
Aug 3, 2023
awsluja
added a commit
that referenced
this pull request
Aug 9, 2023
sobolk
added a commit
that referenced
this pull request
Sep 24, 2023
sobolk
added a commit
that referenced
this pull request
Sep 26, 2023
* Revert "Revert "test: remove extra hash (#13071)" (#13084)" This reverts commit 5013f9a. * test: make upload idempotent * test: make upload idempotent * test: make upload idempotent * test: use ful hash for testing stuff * Update .circleci/local_publish_helpers_codebuild.sh Co-authored-by: Amplifiyer <[email protected]> --------- Co-authored-by: Amplifiyer <[email protected]>
letsbelopez
pushed a commit
to letsbelopez/amplify-cli
that referenced
this pull request
Sep 28, 2023
* Revert "Revert "test: remove extra hash (aws-amplify#13071)" (aws-amplify#13084)" This reverts commit 5013f9a. * test: make upload idempotent * test: make upload idempotent * test: make upload idempotent * test: use ful hash for testing stuff * Update .circleci/local_publish_helpers_codebuild.sh Co-authored-by: Amplifiyer <[email protected]> --------- Co-authored-by: Amplifiyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove extra hash from binary. It's redundant with unique version number.
In E2E tests and PR workflows we use RC version numbering i.e.
<version>-rc.$(git rev-parse --short HEAD)which is unique. There's no need for extra hash embedded in path.Issue #, if available
Description of how you validated changes
E2E tests on CCI and CB running.
https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-cb-e2e%2Fsobkamil%2Fremove-extra-hash
CB link coming.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.