Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: team provider migration #5733

Merged
merged 21 commits into from
Nov 18, 2020

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Oct 29, 2020

Issue #, if available:

Description of changes:

The goal of the PR is to change how we mange third party secrets. The secrets are stored in an ephemeral file called ~/.aws/amplify/deployment-secrets.json. On push-resource the auth for which the secrets are deployed. The change in index.ts intercepts incoming commands to find out if the user has to go through migration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi marked this pull request as draft October 29, 2020 21:40
@ammarkarachi ammarkarachi force-pushed the fix/team-provider branch 5 times, most recently from cdd6e2f to bbf8efd Compare October 29, 2020 23:14
@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request introduces 1 alert when merging bbf8efd into 5d474d3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request introduces 1 alert when merging 6ba672d into 5d474d3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ammarkarachi ammarkarachi force-pushed the fix/team-provider branch 6 times, most recently from c1fa587 to 63eeb4c Compare October 30, 2020 00:45
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 63eeb4c into 7a806b2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@ammarkarachi ammarkarachi changed the title fix: testingnow fix: team provider migration Oct 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 5915ac9 into c0d73a6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging e3ab873 into c0d73a6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #5733 (def4906) into master (f3df233) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5733   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         407      407           
  Lines       18749    18749           
  Branches     3747     3747           
=======================================
  Hits        10903    10903           
  Misses       7164     7164           
  Partials      682      682           
Impacted Files Coverage Δ
.../graphql-transformer-core/src/util/sanity-check.ts 11.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3df233...e5f0a81. Read the comment docs.

@ammarkarachi ammarkarachi force-pushed the fix/team-provider branch 2 times, most recently from 66f5ea1 to f845f01 Compare October 30, 2020 18:08
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging f845f01 into c0d73a6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging e970fe3 into 319a3ae - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 9b63a22 into 319a3ae - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request fixes 1 alert when merging 41fd9a1 into f3df233 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@kaustavghosh06
Copy link
Contributor

@edwardfoyle as a first step - this is moving all the existing structure which is in team-provider to this file. We can do an API review at a later stage if we want to change the structure. Right now in the migration step we're copy pasting what we have in team-provider to out here and using it only for deployments.

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request introduces 1 alert and fixes 1 when merging f929261 into f3df233 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request introduces 4 alerts and fixes 1 when merging 5ebf2af into f3df233 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request fixes 1 alert when merging 6509e6b into f3df233 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@nikhname nikhname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem to contain the changes to getCLIPath we discussed. Are we planning on having those in a separate PR?

@ammarkarachi
Copy link
Contributor Author

This PR doesn't seem to contain the changes to getCLIPath we discussed. Are we planning on having those in a separate PR?
@nikhname

AMPLIFY_PATH: /home/circleci/.npm-global/lib/node_modules/@aws-amplify/cli/bin/amplify

we use AMPLIFY_PATH for that

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request fixes 1 alert when merging 88d55f2 into f3df233 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes, just update enableExternalAuth as we discussed, and store the root stack id, beside amplifyAppId, in case we need it in the future.

@ammarkarachi ammarkarachi merged commit d18f795 into aws-amplify:master Nov 18, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2020

This pull request introduces 1 alert and fixes 1 when merging e5f0a81 into f3df233 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
* fix: using team provider for secrets
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants