-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: team provider migration #5733
fix: team provider migration #5733
Conversation
cdd6e2f
to
bbf8efd
Compare
This pull request introduces 1 alert when merging bbf8efd into 5d474d3 - view on LGTM.com new alerts:
|
bbf8efd
to
6ba672d
Compare
This pull request introduces 1 alert when merging 6ba672d into 5d474d3 - view on LGTM.com new alerts:
|
c1fa587
to
63eeb4c
Compare
This pull request fixes 1 alert when merging 63eeb4c into 7a806b2 - view on LGTM.com fixed alerts:
|
63eeb4c
to
5915ac9
Compare
This pull request fixes 1 alert when merging 5915ac9 into c0d73a6 - view on LGTM.com fixed alerts:
|
5915ac9
to
e3ab873
Compare
This pull request fixes 1 alert when merging e3ab873 into c0d73a6 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5733 +/- ##
=======================================
Coverage 58.15% 58.15%
=======================================
Files 407 407
Lines 18749 18749
Branches 3747 3747
=======================================
Hits 10903 10903
Misses 7164 7164
Partials 682 682
Continue to review full report at Codecov.
|
66f5ea1
to
f845f01
Compare
This pull request fixes 1 alert when merging f845f01 into c0d73a6 - view on LGTM.com fixed alerts:
|
f845f01
to
e970fe3
Compare
This pull request fixes 1 alert when merging e970fe3 into 319a3ae - view on LGTM.com fixed alerts:
|
e970fe3
to
9b63a22
Compare
This pull request fixes 1 alert when merging 9b63a22 into 319a3ae - view on LGTM.com fixed alerts:
|
9465679
to
41fd9a1
Compare
This pull request fixes 1 alert when merging 41fd9a1 into f3df233 - view on LGTM.com fixed alerts:
|
@edwardfoyle as a first step - this is moving all the existing structure which is in team-provider to this file. We can do an API review at a later stage if we want to change the structure. Right now in the migration step we're copy pasting what we have in team-provider to out here and using it only for deployments. |
This pull request introduces 1 alert and fixes 1 when merging f929261 into f3df233 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 1 when merging 5ebf2af into f3df233 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 1 alert when merging 6509e6b into f3df233 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't seem to contain the changes to getCLIPath we discussed. Are we planning on having those in a separate PR?
|
This pull request fixes 1 alert when merging 88d55f2 into f3df233 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes, just update enableExternalAuth
as we discussed, and store the root stack id, beside amplifyAppId
, in case we need it in the future.
This pull request introduces 1 alert and fixes 1 when merging e5f0a81 into f3df233 - view on LGTM.com new alerts:
fixed alerts:
|
* fix: using team provider for secrets
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
The goal of the PR is to change how we mange third party secrets. The secrets are stored in an ephemeral file called ~/.aws/amplify/deployment-secrets.json. On push-resource the auth for which the secrets are deployed. The change in index.ts intercepts incoming commands to find out if the user has to go through migration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.