Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-transformer-core): fix gsi update sanity check #5776

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Nov 4, 2020

allow diff tables to push single gsi changes

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

allow diff tables to push single gsi changes
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #5776 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5776   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         407      407           
  Lines       18747    18747           
  Branches     3745     3745           
=======================================
  Hits        10903    10903           
  Misses       7162     7162           
  Partials      682      682           
Impacted Files Coverage Δ
.../graphql-transformer-core/src/util/sanity-check.ts 11.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955022c...02e92b6. Read the comment docs.

gsiCount += 1;
}
if (gsiCount > 1) {
let diffTableName = diff.path[3];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jhockett jhockett merged commit b82a3e5 into aws-amplify:master Nov 10, 2020
jhockett pushed a commit to jhockett/amplify-cli that referenced this pull request Nov 12, 2020
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants