Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert hostedUIProviderCreds empty array on hostedUI #6485

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Jan 26, 2021

Issue #, if available:
#5942 #6430
Description of changes:
This change check if hostedUI is enabled and if the hostedUIProviderCreds are not available it inserts it

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One nit: Can we also include unit tests to check for empty HostedUI Array to avoid future regression

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants