feat: dont open urls when CLI is running in CI #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
reviewed
Jan 28, 2021
|
This pull request introduces 1 alert when merging 6d98cce into d2bc6d8 - view on LGTM.com new alerts:
|
Updated the CLI not to open browser window when running in CI mode re aws-amplify#5973
edwardfoyle
reviewed
Feb 1, 2021
| @@ -0,0 +1 @@ | |||
| export * from './open'; | |||
There was a problem hiding this comment.
nit can get rid of this file and change the export in the main index.ts to export directly from open.ts
There was a problem hiding this comment.
I'd keep the single level export for clarity as we probably not exporting everything in an upper level directory.
edwardfoyle
approved these changes
Feb 1, 2021
attilah
approved these changes
Feb 2, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CLI not to open browser window when running in CI mode
re #5973
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.