fix(amplify-appsync-simulator): expose errors from util.validate #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the simulator to expose util.errors fix aws-amplify#6068
|
This pull request introduces 4 alerts when merging da22b5b into 5777edd - view on LGTM.com new alerts:
|
attilah
reviewed
Feb 2, 2021
| @@ -57,6 +57,10 @@ export class VelocityTemplate { | |||
| try { | |||
| templateResult = this.compiler.render(context); | |||
| } catch (e) { | |||
| const lastError = context.util.errors.length && context.util.errors[context.util.errors.length - 1]; | |||
There was a problem hiding this comment.
could use: https://lodash.com/docs/4.17.15#last
attilah
reviewed
Feb 2, 2021
| @@ -44,6 +44,24 @@ export async function deploy(transformerOutput: any, client?: DynamoDB) { | |||
| const simulator = await runAppSyncSimulator(config); | |||
| return { simulator, config }; | |||
| } | |||
|
|
|||
| export async function reDeploy( | |||
attilah
reviewed
Feb 2, 2021
| @@ -36,10 +37,12 @@ export class TemplateSentError extends Error { | |||
| export class Unauthorized extends TemplateSentError { | |||
| constructor(gqlMessage, info: GraphQLResolveInfo) { | |||
| super(gqlMessage, 'Unauthorized', {}, {}, info); | |||
| Object.setPrototypeOf(this, Unauthorized.prototype); | |||
There was a problem hiding this comment.
Q: are we using this prototype information elsewhere?
There was a problem hiding this comment.
Without setting this instanceof will not work
attilah
approved these changes
Feb 2, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the simulator to expose util.errors
fix #6068
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.