Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mock handles and prints child proc errors #6601

Merged
merged 5 commits into from
Feb 12, 2021

Conversation

edwardfoyle
Copy link
Contributor

Issue #, if available:
#6311, #6461, #5869

Description of changes:
Ensure stdout and stderr of all mock executors is connected to stdout and stderr or the parent process so that output is printed to the terminal

Also significantly refactored node executor to make the code easier to reason about as well as handle errors in a more robust way

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner February 12, 2021 01:15
@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging 7f66c08 into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging f7d4653 into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging d2fa945 into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #6601 (31eb8eb) into master (819a749) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6601      +/-   ##
==========================================
+ Coverage   56.93%   56.96%   +0.02%     
==========================================
  Files         484      484              
  Lines       21904    21915      +11     
  Branches     4373     4377       +4     
==========================================
+ Hits        12472    12484      +12     
+ Misses       8551     8550       -1     
  Partials      881      881              
Impacted Files Coverage Δ
...amplify-cli-core/src/state-manager/stateManager.ts 45.16% <100.00%> (ø)
packages/amplify-cli-core/src/tags/Tags.ts 90.00% <100.00%> (+11.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dceb13a...4bf1e69. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging 2fe77d5 into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@edwardfoyle edwardfoyle merged commit ce075d9 into aws-amplify:master Feb 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants