-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mock handles and prints child proc errors #6601
fix: mock handles and prints child proc errors #6601
Conversation
This pull request fixes 3 alerts when merging 7f66c08 into 31eb8eb - view on LGTM.com fixed alerts:
|
packages/amplify-python-function-runtime-provider/src/util/invokeUtil.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7f66c08
to
f7d4653
Compare
This pull request fixes 3 alerts when merging f7d4653 into 31eb8eb - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging d2fa945 into 31eb8eb - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6601 +/- ##
==========================================
+ Coverage 56.93% 56.96% +0.02%
==========================================
Files 484 484
Lines 21904 21915 +11
Branches 4373 4377 +4
==========================================
+ Hits 12472 12484 +12
+ Misses 8551 8550 -1
Partials 881 881
Continue to review full report at Codecov.
|
This pull request fixes 3 alerts when merging 2fe77d5 into 31eb8eb - view on LGTM.com fixed alerts:
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#6311, #6461, #5869
Description of changes:
Ensure stdout and stderr of all mock executors is connected to stdout and stderr or the parent process so that output is printed to the terminal
Also significantly refactored node executor to make the code easier to reason about as well as handle errors in a more robust way
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.