Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-appsync-simulator): bail out early on exceptions #6663

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix(amplify-appsync-simulator): bail out early on exceptions #6663

merged 1 commit into from
Mar 1, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 18, 2021

Issue #, if available: #6640

Description of changes: This commit detects templates that use $util.error and stops execution from propagating further.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit detects templates that use $util.error and stops
execution from propagating further.
@cjihrig cjihrig requested a review from a team as a code owner February 18, 2021 03:27
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #6663 (dd65fd8) into master (e746d2a) will increase coverage by 0.00%.
The diff coverage is 69.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6663   +/-   ##
=======================================
  Coverage   56.79%   56.80%           
=======================================
  Files         486      486           
  Lines       22022    22024    +2     
  Branches     4399     4400    +1     
=======================================
+ Hits        12508    12510    +2     
  Misses       8638     8638           
  Partials      876      876           
Impacted Files Coverage Δ
...es/amplify-appsync-simulator/src/velocity/index.ts 76.78% <25.00%> (ø)
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <50.00%> (ø)
...psync-simulator/src/resolvers/pipeline-resolver.ts 93.33% <100.00%> (+0.47%) ⬆️
...y-appsync-simulator/src/resolvers/unit-resolver.ts 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e746d2a...dd65fd8. Read the comment docs.

@yuth yuth self-requested a review February 18, 2021 18:25
@yuth yuth self-assigned this Feb 18, 2021
@yuth yuth merged commit 59d66fe into aws-amplify:master Mar 1, 2021
@cjihrig cjihrig deleted the mock-err branch March 1, 2021 21:08
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants