Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): update oauth prompt help text to mention that selecting "no" will remove existing configuration #6670

Merged
merged 3 commits into from
Feb 18, 2021
Merged

fix(auth): update oauth prompt help text to mention that selecting "no" will remove existing configuration #6670

merged 3 commits into from
Feb 18, 2021

Conversation

rajrajhans
Copy link
Contributor

Issue #, if #available: #6599

Description of changes:
updated oauth prompt help text that appears on doing amplify update auth and selecting I want to learn more under the question "Do you want to use an OAuth flow? " to mention that selecting "no" will remove existing configuration, if any.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rajrajhans rajrajhans requested a review from a team as a code owner February 18, 2021 21:36
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Just one minor wording suggestion

Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #6670 (258b963) into master (e746d2a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6670   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files         486      486           
  Lines       22022    22022           
  Branches     4399     4399           
=======================================
  Hits        12508    12508           
  Misses       8638     8638           
  Partials      876      876           
Impacted Files Coverage Δ
...gory-auth/src/provider-utils/supported-services.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d323c07...258b963. Read the comment docs.

@akshbhu akshbhu merged commit 83ec192 into aws-amplify:master Feb 18, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants