-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): update oauth prompt help text to mention that selecting "no" will remove existing configuration #6670
fix(auth): update oauth prompt help text to mention that selecting "no" will remove existing configuration #6670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Just one minor wording suggestion
packages/amplify-category-auth/src/provider-utils/supported-services.ts
Outdated
Show resolved
Hide resolved
…rvices.ts Co-authored-by: Edward Foyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
packages/amplify-category-auth/src/provider-utils/supported-services.ts
Outdated
Show resolved
Hide resolved
…rvices.ts Co-authored-by: Rene Brandel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6670 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 486 486
Lines 22022 22022
Branches 4399 4399
=======================================
Hits 12508 12508
Misses 8638 8638
Partials 876 876
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if #available: #6599
Description of changes:
updated oauth prompt help text that appears on doing
amplify update auth
and selectingI want to learn more
under the question "Do you want to use an OAuth flow? " to mention that selecting "no" will remove existing configuration, if any.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.