Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplify-codegen): Migrate codegen #6730

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Feb 24, 2021

Issue #, if available:

Description of changes:

  • Bump the codegen to a new minor version published from the new repo. The packages involved: amplify-cli, amplify-provider-awscloudformation, amplify-util-mock
  • Remove the old package
  • Change the plugin version matching method so that it works with SemVer. This change mainly addresses the version unmatching for codegen's caret version.
    image
  • Add codegen to nohoist of yarn workspace in order to be scanned by CLI in case of using yarn setup-dev and amplify-dev. Details: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested a review from a team as a code owner February 24, 2021 20:23
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #6730 (990e8c7) into master (59d66fe) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6730      +/-   ##
==========================================
- Coverage   56.84%   56.50%   -0.35%     
==========================================
  Files         487      430      -57     
  Lines       22076    21088     -988     
  Branches     4414     4223     -191     
==========================================
- Hits        12550    11916     -634     
+ Misses       8649     8370     -279     
+ Partials      877      802      -75     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d66fe...990e8c7. Read the comment docs.

@AaronZyLee AaronZyLee force-pushed the migrateCodegen branch 2 times, most recently from 74091cc to 6e23141 Compare February 25, 2021 00:13
@attilah attilah merged commit 9c7a69a into aws-amplify:master Mar 2, 2021
@AaronZyLee AaronZyLee deleted the migrateCodegen branch March 3, 2021 17:50
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants