From 310aff40f483ff0433d8199b46d3acca05110e78 Mon Sep 17 00:00:00 2001 From: awsluja Date: Fri, 26 May 2023 16:13:38 -0400 Subject: [PATCH 1/4] ci: draft codeowners for codebuild --- .github/CODEOWNERS | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9923f440cbb..b56b8c04d5b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,15 @@ # Amplify CLI Team owns the full repo by default. -* @aws-amplify/amplify-cli + +- @aws-amplify/amplify-cli # Add Data team folks focused on GQL transform/codegen to ownership for packages which will be migrated, in addition to the existing cli team. + /packages/amplify-graphiql-explorer @aws-amplify/amplify-cli @aws-amplify/amplify-data-buildtime /packages/amplify-velocity-template @aws-amplify/amplify-cli @aws-amplify/amplify-data-buildtime + +# Add folks focused on reviewing changes to CI/CD scripts/buildspecs + +/.circleci/ @awsluja @sobolk +/scripts/ @awsluja @sobolk +/shared-scripts.sh @awsluja @goldbez +/codebuild_specs/ @awsluja @goldbez From c72bfe2acd06fab3b3ef5f4ce3366f581dbf540e Mon Sep 17 00:00:00 2001 From: awsluja Date: Fri, 26 May 2023 16:17:37 -0400 Subject: [PATCH 2/4] ci: fix autocorrect --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b56b8c04d5b..374e2a83957 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ # Amplify CLI Team owns the full repo by default. -- @aws-amplify/amplify-cli +* @aws-amplify/amplify-cli # Add Data team folks focused on GQL transform/codegen to ownership for packages which will be migrated, in addition to the existing cli team. From 5658873a4d55dc56db19cbbafe7f650f7a60e191 Mon Sep 17 00:00:00 2001 From: awsluja <110861985+awsluja@users.noreply.github.com> Date: Fri, 26 May 2023 16:24:31 -0400 Subject: [PATCH 3/4] Update .github/CODEOWNERS to include admins Co-authored-by: Kamil Sobol --- .github/CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 374e2a83957..3bb7274b762 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,7 +9,7 @@ # Add folks focused on reviewing changes to CI/CD scripts/buildspecs -/.circleci/ @awsluja @sobolk -/scripts/ @awsluja @sobolk -/shared-scripts.sh @awsluja @goldbez -/codebuild_specs/ @awsluja @goldbez +/.circleci/ @awsluja @sobolk @aws-amplify/amplify-cli-admins +/scripts/ @awsluja @sobolk @aws-amplify/amplify-cli-admins +/shared-scripts.sh @awsluja @goldbez @aws-amplify/amplify-cli-admins +/codebuild_specs/ @awsluja @goldbez @aws-amplify/amplify-cli-admins From 08b500432685c9b90f6f3a8b66c7e8e1c7e88165 Mon Sep 17 00:00:00 2001 From: awsluja Date: Fri, 26 May 2023 17:07:06 -0400 Subject: [PATCH 4/4] ci: use only admins list --- .github/CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 3bb7274b762..14c024fc20c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,7 +9,7 @@ # Add folks focused on reviewing changes to CI/CD scripts/buildspecs -/.circleci/ @awsluja @sobolk @aws-amplify/amplify-cli-admins -/scripts/ @awsluja @sobolk @aws-amplify/amplify-cli-admins -/shared-scripts.sh @awsluja @goldbez @aws-amplify/amplify-cli-admins -/codebuild_specs/ @awsluja @goldbez @aws-amplify/amplify-cli-admins +/.circleci/ @aws-amplify/amplify-cli-admins +/scripts/ @aws-amplify/amplify-cli-admins +/shared-scripts.sh @aws-amplify/amplify-cli-admins +/codebuild_specs/ @aws-amplify/amplify-cli-admins