From 566fcd64a748c546fde93bf038ee96426097443f Mon Sep 17 00:00:00 2001 From: Kamil Sobol Date: Wed, 6 Sep 2023 14:23:23 -0700 Subject: [PATCH] chore: require amplify cli admin to approve PRs --- .github/CODEOWNERS | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 02bc509349d..8afa9e14604 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,16 +1,7 @@ -# Amplify CLI Team owns the full repo by default. - -* @aws-amplify/amplify-cli +# Require at least one Amplify CLI Admin to approve changes. +# Non-admin reviewers participate in pull request review quorum by having write access to repository. +* @aws-amplify/amplify-cli-admins # Add Data team folks focused on GQL transform/codegen to ownership for packages which will be migrated, in addition to the existing cli team. - -/packages/amplify-graphiql-explorer @aws-amplify/amplify-cli @aws-amplify/amplify-data-buildtime -/packages/amplify-velocity-template @aws-amplify/amplify-cli @aws-amplify/amplify-data-buildtime - -# Add folks focused on reviewing changes to CI/CD scripts/buildspecs - -/.circleci/ @aws-amplify/amplify-cli-admins -/.github/ @aws-amplify/amplify-cli-admins -/scripts/ @aws-amplify/amplify-cli-admins -/shared-scripts.sh @aws-amplify/amplify-cli-admins -/codebuild_specs/ @aws-amplify/amplify-cli-admins +/packages/amplify-graphiql-explorer @aws-amplify/amplify-cli-admins @aws-amplify/amplify-data-buildtime +/packages/amplify-velocity-template @aws-amplify/amplify-cli-admins @aws-amplify/amplify-data-buildtime