junit
diff --git a/aws-android-sdk-ddb-mapper/src/main/java/com/amazonaws/mobileconnectors/dynamodbv2/dynamodbmapper/DynamoDBMapper.java b/aws-android-sdk-ddb-mapper/src/main/java/com/amazonaws/mobileconnectors/dynamodbv2/dynamodbmapper/DynamoDBMapper.java
index 28095fa45f..354631eec4 100644
--- a/aws-android-sdk-ddb-mapper/src/main/java/com/amazonaws/mobileconnectors/dynamodbv2/dynamodbmapper/DynamoDBMapper.java
+++ b/aws-android-sdk-ddb-mapper/src/main/java/com/amazonaws/mobileconnectors/dynamodbv2/dynamodbmapper/DynamoDBMapper.java
@@ -91,45 +91,45 @@
*
* @DynamoDBTable(tableName = "TestTable")
* public class TestClass {
- *
+ *
* private Long key;
* private double rangeKey;
* private Long version;
- *
+ *
* private Set<Integer> integerSetAttribute;
- *
+ *
* @DynamoDBHashKey
* public Long getKey() {
* return key;
* }
- *
+ *
* public void setKey(Long key) {
* this.key = key;
* }
- *
+ *
* @DynamoDBRangeKey
* public double getRangeKey() {
* return rangeKey;
* }
- *
+ *
* public void setRangeKey(double rangeKey) {
* this.rangeKey = rangeKey;
* }
- *
+ *
* @DynamoDBAttribute(attributeName = "integerSetAttribute")
* public Set<Integer> getIntegerAttribute() {
* return integerSetAttribute;
* }
- *
+ *
* public void setIntegerAttribute(Set<Integer> integerAttribute) {
* this.integerSetAttribute = integerAttribute;
* }
- *
+ *
* @DynamoDBVersionAttribute
* public Long getVersion() {
* return version;
* }
- *
+ *
* public void setVersion(Long version) {
* this.version = version;
* }
@@ -317,7 +317,7 @@ public DynamoDBMapper(
if (s3CredentialsProvider == null) {
this.s3cc = null;
} else {
- this.s3cc = new S3ClientCache(s3CredentialsProvider.getCredentials());
+ this.s3cc = new S3ClientCache(s3CredentialsProvider);
}
}
@@ -374,29 +374,30 @@ public T load(T keyObject) {
*/
public T load(T keyObject, DynamoDBMapperConfig config) {
@SuppressWarnings("unchecked")
+ final
Class clazz = (Class) keyObject.getClass();
config = mergeConfig(config);
- ItemConverter converter = getConverter(config);
+ final ItemConverter converter = getConverter(config);
- String tableName = getTableName(clazz, keyObject, config);
+ final String tableName = getTableName(clazz, keyObject, config);
- GetItemRequest rq = new GetItemRequest()
+ final GetItemRequest rq = new GetItemRequest()
.withRequestMetricCollector(config.getRequestMetricCollector());
- Map key = getKey(converter, keyObject, clazz);
+ final Map key = getKey(converter, keyObject, clazz);
rq.setKey(key);
rq.setTableName(tableName);
rq.setConsistentRead(config.getConsistentReads() == ConsistentReads.CONSISTENT);
- GetItemResult item = db.getItem(applyUserAgent(rq));
- Map itemAttributes = item.getItem();
+ final GetItemResult item = db.getItem(applyUserAgent(rq));
+ final Map itemAttributes = item.getItem();
if (itemAttributes == null) {
return null;
}
- T object = privateMarshallIntoObject(
+ final T object = privateMarshallIntoObject(
converter,
toParameters(itemAttributes, clazz, tableName, config));
@@ -422,12 +423,12 @@ private Map getKey(
T keyObject,
Class clazz) {
- Map key = new HashMap();
- for (Method keyGetter : reflector.getPrimaryKeyGetters(clazz)) {
- Object getterResult =
+ final Map key = new HashMap();
+ for (final Method keyGetter : reflector.getPrimaryKeyGetters(clazz)) {
+ final Object getterResult =
ReflectionUtils.safeInvoke(keyGetter, keyObject);
- AttributeValue keyAttributeValue =
+ final AttributeValue keyAttributeValue =
converter.convert(keyGetter, getterResult);
if (keyAttributeValue == null) {
@@ -462,7 +463,7 @@ private Map getKey(
public T load(Class clazz, Object hashKey, Object rangeKey,
DynamoDBMapperConfig config) {
config = mergeConfig(config);
- T keyObject = createKeyObject(clazz, hashKey, rangeKey);
+ final T keyObject = createKeyObject(clazz, hashKey, rangeKey);
return load(keyObject, config);
}
@@ -474,12 +475,12 @@ T createKeyObject(Class clazz, Object hashKey, Object rangeKey) {
T keyObject = null;
try {
keyObject = clazz.newInstance();
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new DynamoDBMappingException("Failed to instantiate class", e);
}
boolean seenHashKey = false;
boolean seenRangeKey = false;
- for (Method getter : reflector.getPrimaryKeyGetters(clazz)) {
+ for (final Method getter : reflector.getPrimaryKeyGetters(clazz)) {
if (ReflectionUtils.getterOrFieldHasAnnotation(getter, DynamoDBHashKey.class)) {
if (seenHashKey) {
throw new DynamoDBMappingException(
@@ -529,18 +530,18 @@ private Map getHashKeyEqualsConditions(
ItemConverter converter,
Object obj) {
- Map conditions = new HashMap();
+ final Map conditions = new HashMap();
if (obj == null) {
return conditions;
}
- for (Method getter : reflector.getRelevantGetters(obj.getClass())) {
+ for (final Method getter : reflector.getRelevantGetters(obj.getClass())) {
if (ReflectionUtils.getterOrFieldHasAnnotation(
getter, DynamoDBHashKey.class)
|| ReflectionUtils.getterOrFieldHasAnnotation(
getter, DynamoDBIndexHashKey.class)) {
- Object getterReturnResult =
+ final Object getterReturnResult =
ReflectionUtils.safeInvoke(getter, obj);
if (getterReturnResult != null) {
@@ -581,7 +582,7 @@ static String internalGetTableName(final Class clazz,
final DynamoDBMapperConfig config) {
// Resolve by object, if possible and desired
- DynamoDBMapperConfig.ObjectTableNameResolver objectResolver = config
+ final DynamoDBMapperConfig.ObjectTableNameResolver objectResolver = config
.getObjectTableNameResolver();
if (object != null && objectResolver != null) {
return objectResolver.getTableName(object, config);
@@ -614,9 +615,9 @@ public T marshallIntoObject(
Class clazz,
Map itemAttributes) {
- ItemConverter converter = getConverter(config);
+ final ItemConverter converter = getConverter(config);
- String tableName = getTableName(clazz, config);
+ final String tableName = getTableName(clazz, config);
return privateMarshallIntoObject(
converter,
@@ -630,8 +631,8 @@ private T privateMarshallIntoObject(
ItemConverter converter,
AttributeTransformer.Parameters parameters) {
- Class clazz = parameters.getModelClass();
- Map values = untransformAttributes(parameters);
+ final Class clazz = parameters.getModelClass();
+ final Map values = untransformAttributes(parameters);
return converter.unconvert(clazz, values);
}
@@ -646,8 +647,8 @@ private T privateMarshallIntoObject(
*/
public List marshallIntoObjects(Class clazz,
List> itemAttributes) {
- List result = new ArrayList(itemAttributes.size());
- for (Map item : itemAttributes) {
+ final List result = new ArrayList(itemAttributes.size());
+ for (final Map item : itemAttributes) {
result.add(marshallIntoObject(clazz, item));
}
return result;
@@ -664,14 +665,14 @@ public List marshallIntoObjects(Class clazz,
final List marshallIntoObjects(
final List> parameters
) {
- List result = new ArrayList(parameters.size());
+ final List result = new ArrayList(parameters.size());
ItemConverter converter = null;
if (!parameters.isEmpty()) {
converter = getConverter(parameters.get(0).getMapperConfig());
}
- for (AttributeTransformer.Parameters entry : parameters) {
+ for (final AttributeTransformer.Parameters entry : parameters) {
result.add(privateMarshallIntoObject(converter, entry));
}
@@ -700,15 +701,15 @@ public void save(T object, DynamoDBSaveExpression saveExpress
}
boolean needAutoGenerateAssignableKey(Class clazz, Object object) {
- Collection keyGetters = reflector.getPrimaryKeyGetters(clazz);
+ final Collection keyGetters = reflector.getPrimaryKeyGetters(clazz);
boolean forcePut = false;
/*
* Determine if there are any auto-assigned keys to assign. If so, force
* a put and assign the keys.
*/
boolean hashKeyGetterFound = false;
- for (Method method : keyGetters) {
- Object getterResult = ReflectionUtils.safeInvoke(method, object);
+ for (final Method method : keyGetters) {
+ final Object getterResult = ReflectionUtils.safeInvoke(method, object);
if (getterResult == null && reflector.isAssignableKey(method)) {
forcePut = true;
}
@@ -768,15 +769,15 @@ public void save(T object, DynamoDBSaveExpression saveExpress
final ItemConverter converter = getConverter(finalConfig);
@SuppressWarnings("unchecked")
- Class clazz = (Class) object.getClass();
- String tableName = getTableName(clazz, object, finalConfig);
+ final Class clazz = (Class) object.getClass();
+ final String tableName = getTableName(clazz, object, finalConfig);
/*
* We force a putItem request instead of updateItem request either when
* CLOBBER is configured, or part of the primary key of the object needs
* to be auto-generated.
*/
- boolean forcePut = (finalConfig.getSaveBehavior() == SaveBehavior.CLOBBER)
+ final boolean forcePut = (finalConfig.getSaveBehavior() == SaveBehavior.CLOBBER)
|| needAutoGenerateAssignableKey(clazz, object);
SaveObjectHandler saveObjectHandler;
@@ -870,7 +871,7 @@ protected void onNullNonKeyAttribute(String attributeName) {
@Override
protected void executeLowLevelRequest() {
- UpdateItemResult updateItemResult = doUpdateItem();
+ final UpdateItemResult updateItemResult = doUpdateItem();
// The UpdateItem request is specified to return ALL_NEW
// attributes of the affected item. So if the returned
@@ -886,7 +887,7 @@ protected void executeLowLevelRequest() {
// the key attributes (prepared for the
// UpdateItemRequest) into the AttributeValueUpdates
// collection.
- for (String keyAttributeName : getKeyAttributeValues().keySet()) {
+ for (final String keyAttributeName : getKeyAttributeValues().keySet()) {
getAttributeValueUpdates().put(
keyAttributeName,
new AttributeValueUpdate()
@@ -984,21 +985,21 @@ public SaveObjectHandler(
* The general workflow of a save operation.
*/
public void execute() {
- Collection keyGetters = reflector.getPrimaryKeyGetters(clazz);
+ final Collection keyGetters = reflector.getPrimaryKeyGetters(clazz);
/*
* First handle keys
*/
- for (Method method : keyGetters) {
- Object getterResult = ReflectionUtils.safeInvoke(method, object);
- String attributeName = reflector.getAttributeName(method);
+ for (final Method method : keyGetters) {
+ final Object getterResult = ReflectionUtils.safeInvoke(method, object);
+ final String attributeName = reflector.getAttributeName(method);
if (getterResult == null && reflector.isAssignableKey(method)) {
onAutoGenerateAssignableKey(method, attributeName);
}
else {
- AttributeValue newAttributeValue = converter.convert(method, getterResult);
+ final AttributeValue newAttributeValue = converter.convert(method, getterResult);
if (newAttributeValue == null) {
throw new DynamoDBMappingException(
"Null or empty value for key: " + method);
@@ -1021,14 +1022,15 @@ public void execute() {
/*
* Next construct an update for every non-key property
*/
- for (Method method : reflector.getRelevantGetters(clazz)) {
+ for (final Method method : reflector.getRelevantGetters(clazz)) {
// Skip any key methods, since they are handled separately
- if (keyGetters.contains(method))
+ if (keyGetters.contains(method)) {
continue;
+ }
- Object getterResult = ReflectionUtils.safeInvoke(method, object);
- String attributeName = reflector.getAttributeName(method);
+ final Object getterResult = ReflectionUtils.safeInvoke(method, object);
+ final String attributeName = reflector.getAttributeName(method);
/*
* If this is a versioned field, update it
@@ -1041,7 +1043,7 @@ public void execute() {
* Otherwise apply the update value for this attribute.
*/
else {
- AttributeValue currentValue = converter.convert(method, getterResult);
+ final AttributeValue currentValue = converter.convert(method, getterResult);
if (currentValue != null) {
onNonKeyAttribute(attributeName, currentValue);
} else {
@@ -1061,7 +1063,7 @@ public void execute() {
* currently takes into account of auto-generated keys and versioned
* attributes.
*/
- for (ValueUpdate update : inMemoryUpdates) {
+ for (final ValueUpdate update : inMemoryUpdates) {
update.apply();
}
}
@@ -1155,7 +1157,7 @@ protected List getInMemoryUpdates() {
* the returned attributes to detect silent failure on the server-side.
*/
protected UpdateItemResult doUpdateItem() {
- UpdateItemRequest req = new UpdateItemRequest()
+ final UpdateItemRequest req = new UpdateItemRequest()
.withTableName(getTableName())
.withKey(getKeyAttributeValues())
.withAttributeUpdates(
@@ -1192,7 +1194,7 @@ protected PutItemResult doPutItem() {
this.clazz,
getTableName(),
saveConfig));
- PutItemRequest req = new PutItemRequest()
+ final PutItemRequest req = new PutItemRequest()
.withTableName(getTableName())
.withItem(attributeValues)
.withExpected(mergeExpectedAttributeValueConditions())
@@ -1203,7 +1205,7 @@ protected PutItemResult doPutItem() {
}
private void onAutoGenerateAssignableKey(Method method, String attributeName) {
- AttributeValue newVersionValue = getAutoGeneratedKeyAttributeValue(converter, method);
+ final AttributeValue newVersionValue = getAutoGeneratedKeyAttributeValue(converter, method);
updateValues.put(attributeName,
new AttributeValueUpdate().withAction("PUT").withValue(newVersionValue));
@@ -1213,7 +1215,7 @@ private void onAutoGenerateAssignableKey(Method method, String attributeName) {
&& !internalExpectedValueAssertions.containsKey(attributeName)) {
// Add an expect clause to make sure that the item
// doesn't already exist, since it's supposed to be new
- ExpectedAttributeValue expected = new ExpectedAttributeValue();
+ final ExpectedAttributeValue expected = new ExpectedAttributeValue();
expected.setExists(false);
internalExpectedValueAssertions.put(attributeName, expected);
}
@@ -1225,11 +1227,11 @@ private void onVersionAttribute(Method method, Object getterResult,
&& !internalExpectedValueAssertions.containsKey(attributeName)) {
// First establish the expected (current) value for the
// update call
- ExpectedAttributeValue expected = new ExpectedAttributeValue();
+ final ExpectedAttributeValue expected = new ExpectedAttributeValue();
// For new objects, insist that the value doesn't exist.
// For existing ones, insist it has the old value.
- AttributeValue currentValue = converter.convert(method, getterResult);
+ final AttributeValue currentValue = converter.convert(method, getterResult);
expected.setExists(currentValue != null);
if (currentValue != null) {
expected.setValue(currentValue);
@@ -1237,8 +1239,8 @@ private void onVersionAttribute(Method method, Object getterResult,
internalExpectedValueAssertions.put(attributeName, expected);
}
- Object newVersion = incrementor.increment(method, getterResult);
- AttributeValue newVersionValue = converter.convert(method, newVersion);
+ final Object newVersion = incrementor.increment(method, getterResult);
+ final AttributeValue newVersionValue = converter.convert(method, newVersion);
updateValues.put(attributeName, new AttributeValueUpdate()
.withAction("PUT")
.withValue(newVersionValue));
@@ -1285,33 +1287,34 @@ public void delete(Object object, DynamoDBMapperConfig config) {
public void delete(T object, DynamoDBDeleteExpression deleteExpression,
DynamoDBMapperConfig config) {
config = mergeConfig(config);
- ItemConverter converter = getConverter(config);
+ final ItemConverter converter = getConverter(config);
@SuppressWarnings("unchecked")
- Class clazz = (Class) object.getClass();
+ final Class clazz = (Class) object.getClass();
- String tableName = getTableName(clazz, object, config);
+ final String tableName = getTableName(clazz, object, config);
- Map key = getKey(converter, object, clazz);
+ final Map key = getKey(converter, object, clazz);
/*
* If there is a version field, make sure we assert its value. If the
* version field is null (only should happen in unusual circumstances),
* pretend it doesn't have a version field after all.
*/
- Map internalAssertions = new HashMap();
+ final Map internalAssertions = new HashMap();
if (config.getSaveBehavior() != SaveBehavior.CLOBBER) {
- for (Method method : reflector.getRelevantGetters(clazz)) {
+ for (final Method method : reflector.getRelevantGetters(clazz)) {
if (reflector.isVersionAttributeGetter(method)) {
- Object getterResult = ReflectionUtils.safeInvoke(method, object);
- String attributeName = reflector.getAttributeName(method);
+ final Object getterResult = ReflectionUtils.safeInvoke(method, object);
+ final String attributeName = reflector.getAttributeName(method);
- ExpectedAttributeValue expected = new ExpectedAttributeValue();
- AttributeValue currentValue = converter.convert(method, getterResult);
+ final ExpectedAttributeValue expected = new ExpectedAttributeValue();
+ final AttributeValue currentValue = converter.convert(method, getterResult);
expected.setExists(currentValue != null);
- if (currentValue != null)
+ if (currentValue != null) {
expected.setValue(currentValue);
+ }
internalAssertions.put(attributeName, expected);
break;
}
@@ -1323,7 +1326,7 @@ public void delete(T object, DynamoDBDeleteExpression deleteExpression,
.withRequestMetricCollector(config.getRequestMetricCollector());
if (deleteExpression != null) {
- String conditionalExpression = deleteExpression.getConditionExpression();
+ final String conditionalExpression = deleteExpression.getConditionExpression();
if (conditionalExpression != null) {
if (internalAssertions != null && !internalAssertions.isEmpty()) {
@@ -1470,25 +1473,25 @@ public List batchWrite(List objectsToWrite,
List objectsToDelete, DynamoDBMapperConfig config) {
config = mergeConfig(config);
- List totalFailedBatches = new LinkedList();
+ final List totalFailedBatches = new LinkedList();
- HashMap> requestItems = new HashMap>();
+ final HashMap> requestItems = new HashMap>();
- ItemConverter converter = getConverter(config);
+ final ItemConverter converter = getConverter(config);
- List inMemoryUpdates = new LinkedList();
- for (Object toWrite : objectsToWrite) {
- Class clazz = toWrite.getClass();
- String tableName = getTableName(clazz, toWrite, config);
+ final List inMemoryUpdates = new LinkedList();
+ for (final Object toWrite : objectsToWrite) {
+ final Class clazz = toWrite.getClass();
+ final String tableName = getTableName(clazz, toWrite, config);
- Map attributeValues = new HashMap();
+ final Map attributeValues = new HashMap();
// Look at every getter and construct a value object for it
- for (Method method : reflector.getRelevantGetters(clazz)) {
- Object getterResult =
+ for (final Method method : reflector.getRelevantGetters(clazz)) {
+ final Object getterResult =
ReflectionUtils.safeInvoke(method, toWrite);
- String attributeName = reflector.getAttributeName(method);
+ final String attributeName = reflector.getAttributeName(method);
AttributeValue currentValue = null;
if (getterResult == null && reflector.isAssignableKey(method)) {
@@ -1507,7 +1510,7 @@ public List batchWrite(List objectsToWrite,
requestItems.put(tableName, new LinkedList());
}
- AttributeTransformer.Parameters parameters =
+ final AttributeTransformer.Parameters parameters =
toParameters(attributeValues, clazz, tableName, config);
requestItems.get(tableName).add(
@@ -1516,12 +1519,12 @@ public List batchWrite(List objectsToWrite,
transformAttributes(parameters))));
}
- for (Object toDelete : objectsToDelete) {
- Class clazz = toDelete.getClass();
+ for (final Object toDelete : objectsToDelete) {
+ final Class clazz = toDelete.getClass();
- String tableName = getTableName(clazz, toDelete, config);
+ final String tableName = getTableName(clazz, toDelete, config);
- Map key = getKey(converter, toDelete);
+ final Map key = getKey(converter, toDelete);
if (!requestItems.containsKey(tableName)) {
requestItems.put(tableName, new LinkedList());
@@ -1534,22 +1537,22 @@ public List batchWrite(List objectsToWrite,
// Break into chunks of 25 items and make service requests to DynamoDB
while (!requestItems.isEmpty()) {
- HashMap> batch =
+ final HashMap> batch =
new HashMap>();
int i = 0;
- Iterator>> tableIter = requestItems.entrySet()
+ final Iterator>> tableIter = requestItems.entrySet()
.iterator();
while (tableIter.hasNext() && i < MAX_ITEMS_PER_BATCH) {
- Entry> tableRequest = tableIter.next();
+ final Entry> tableRequest = tableIter.next();
batch.put(tableRequest.getKey(), new LinkedList());
- Iterator writeRequestIter = tableRequest.getValue().iterator();
+ final Iterator writeRequestIter = tableRequest.getValue().iterator();
while (writeRequestIter.hasNext() && i++ < MAX_ITEMS_PER_BATCH) {
- WriteRequest writeRequest = writeRequestIter.next();
+ final WriteRequest writeRequest = writeRequestIter.next();
batch.get(tableRequest.getKey()).add(writeRequest);
writeRequestIter.remove();
}
@@ -1561,7 +1564,7 @@ public List batchWrite(List objectsToWrite,
}
}
- List failedBatches = writeOneBatch(batch);
+ final List failedBatches = writeOneBatch(batch);
if (failedBatches != null) {
totalFailedBatches.addAll(failedBatches);
@@ -1569,7 +1572,7 @@ public List batchWrite(List objectsToWrite,
if (containsThrottlingException(failedBatches)) {
try {
Thread.sleep(1000 * 2);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
Thread.currentThread().interrupt();
throw new AmazonClientException(e.getMessage(), e);
}
@@ -1578,7 +1581,7 @@ public List batchWrite(List objectsToWrite,
}
// Once the entire batch is processed, update assigned keys in memory
- for (ValueUpdate update : inMemoryUpdates) {
+ for (final ValueUpdate update : inMemoryUpdates) {
update.apply();
}
@@ -1592,10 +1595,10 @@ public List batchWrite(List objectsToWrite,
*/
List writeOneBatch(Map> batch) {
- List failedBatches = new LinkedList();
- Map> firstHalfBatch = new HashMap>();
- Map> secondHalfBatch = new HashMap>();
- FailedBatch failedBatch = callUntilCompletion(batch);
+ final List failedBatches = new LinkedList();
+ final Map> firstHalfBatch = new HashMap>();
+ final Map> secondHalfBatch = new HashMap>();
+ final FailedBatch failedBatch = callUntilCompletion(batch);
if (failedBatch != null) {
// If the exception is request entity too large, we divide the batch
@@ -1629,8 +1632,8 @@ List writeOneBatch(Map> batch) {
* Check whether there are throttling exception in the failed batches.
*/
boolean containsThrottlingException(List failedBatches) {
- for (FailedBatch failedBatch : failedBatches) {
- Exception e = failedBatch.getException();
+ for (final FailedBatch failedBatch : failedBatches) {
+ final Exception e = failedBatch.getException();
if (e instanceof AmazonServiceException
&& RetryUtils.isThrottlingException((AmazonServiceException) e)) {
return true;
@@ -1646,13 +1649,13 @@ boolean containsThrottlingException(List failedBatches) {
private void divideBatch(Map> batch,
Map> firstHalfBatch,
Map> secondHalfBatch) {
- for (String key : batch.keySet()) {
+ for (final String key : batch.keySet()) {
- List requests = batch.get(key);
+ final List requests = batch.get(key);
- List firstHalfRequests = requests.subList(0, requests.size() / 2);
+ final List firstHalfRequests = requests.subList(0, requests.size() / 2);
- List secondHalfRequests = requests.subList(requests.size() / 2,
+ final List secondHalfRequests = requests.subList(requests.size() / 2,
requests.size());
firstHalfBatch.put(key, firstHalfRequests);
@@ -1671,7 +1674,7 @@ private int computeFailedBatchSize(FailedBatch failedBatch) {
int count = 0;
- for (String tableName : failedBatch.getUnprocessedItems().keySet()) {
+ for (final String tableName : failedBatch.getUnprocessedItems().keySet()) {
count += failedBatch.getUnprocessedItems().get(tableName).size();
}
return count;
@@ -1690,7 +1693,7 @@ private FailedBatch callUntilCompletion(Map> batch) {
try {
result = db.batchWriteItem(applyBatchOperationUserAgent(
new BatchWriteItemRequest().withRequestItems(batch)));
- } catch (Exception e) {
+ } catch (final Exception e) {
failedBatch = new FailedBatch();
failedBatch.setUnprocessedItems(batch);
failedBatch.setException(e);
@@ -1737,23 +1740,23 @@ public Map> batchLoad(List