Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportValue replaced by !GetAtt #583

Closed
s-schneider opened this issue Nov 7, 2024 · 5 comments · Fixed by #632
Closed

ImportValue replaced by !GetAtt #583

s-schneider opened this issue Nov 7, 2024 · 5 comments · Fixed by #632
Assignees
Labels
bug Something isn't working

Comments

@s-schneider
Copy link

it seems that since the last update Fn::ImportValue: is replaced with !GetAtt using rain merge *.yaml. Is that a known issue?

See the attached yaml files
cloudformation.zip

@ericzbeard
Copy link
Contributor

That was on purpose, since if you're merging templates, there's no point in importing a value that's now in the same template. Is this a breaking change for you?

@s-schneider
Copy link
Author

In our case it is breaking, because we are first merging the templates and importing that value on deploy from another stack on aws, outside the templates

@ericzbeard
Copy link
Contributor

I'm not sure I understand. Exported names are unique, so how would you have the export in this merged template and also in another one?

@sandymay-dd
Copy link

sandymay-dd commented Jan 22, 2025

Hi @ericzbeard - We are facing the same issue having upgraded and this is a breaking change for us. We follow the same scenario as @s-schneider, if I've read it correctly.

We export a value from a cloudformation stack (Stack A). The template.yaml that provisions Stack A is not a template that we are using in a rain merge.

We have a collection of smaller templates that we use rain merge to provision Stack B. Stack B imports the export from Stack A.

Therefore when merging the templates, we can no longer import a value that is exported from a different cloudformation stack as rain has converted the `ImportValue! to !GetAtt.

We are using an earlier version of rain to work around this issue.

@ericzbeard ericzbeard self-assigned this Jan 22, 2025
@ericzbeard ericzbeard added the bug Something isn't working label Jan 22, 2025
@sandymay-dd
Copy link

Thanks for responding so quickly @ericzbeard 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants