Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: remove @faker-js/faker dependency #3480

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 16, 2025 · 2 comments · Fixed by #3476
Closed
1 of 2 tasks

Maintenance: remove @faker-js/faker dependency #3480

dreamorosi opened this issue Jan 16, 2025 · 2 comments · Fixed by #3476
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

The Parser unit test introduced a dependency @faker-js/faker that is used very sparingly throughout the tests. In an effort to keep the dependency surface area small, we should try to remove it.

Why is this needed?

So that we can avoid having an extra dependency for a single usage.

Which area does this relate to?

Other

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility labels Jan 16, 2025
@dreamorosi dreamorosi moved this from Triage to Pending review in Powertools for AWS Lambda (TypeScript) Jan 16, 2025
@dreamorosi dreamorosi mentioned this issue Jan 16, 2025
Merged
@dreamorosi dreamorosi linked a pull request Jan 16, 2025 that will close this issue
chore(parser): remove faker dependency #3476
Merged
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Jan 16, 2025
@dreamorosi dreamorosi self-assigned this Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jan 16, 2025
@dreamorosi dreamorosi mentioned this issue Jan 20, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.13.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jan 28, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(parser): remove faker dependency svozza/powertools-lambda-typescript
1 participant
@dreamorosi