Why does app.tsx directly import infrastructure config?

[dfkunstler]

aws-genai-llm-chatbot/lib/user-interface/react-app/src/app.tsx

Line 19 in bb0fe23

import * as InfraConfig from '../../../../bin/config.json';

I believe the reference above was introduced in 4.0.2.

My question is, why create an explicit dependency on config.json, which isn't part of the source tree, when a default config available? Obviously we expect people to generate a config, but prior to this release it was possible to do a clean build from source using the default config produced by config.ts:

aws-genai-llm-chatbot/bin/config.ts

Line 6 in bb0fe23

return JSON.parse(readFileSync("./bin/config.json").toString("utf8"));

IMO that default config mechanism is important. It gives us a way to test that a new release works as shipped before introducing local config (typically generated by a previous release). Then if build fails for any reason, we can easily determine if previous local config is the source of the trouble.

I assume that it was implemented this way to avoid a dependency between runtime app code and infrastructure code, and i certainly support that choice. If that's the case, then i'd argue it should extend also to configuration files. Application runtime config should separate from infrastructure config (as in the aws-exports.json file).

Apologies in advance if i've misunderstood something. Thanks for taking the time to explain.

[bigadsoleiman]

Hi @dfkunstler thanks for pointing this out
importing a file from the CDK domain into the react-app domain was simply wrong.

This has been addressed with #367