Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sessionId in first open and session start events #54

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. fix the sessionId in first open and session start event
  2. optimize session initialization

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Mar 5, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 5, 2024 03:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.71%. Comparing base (63e1df1) to head (5fec479).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   95.66%   95.71%   +0.04%     
==========================================
  Files          35       35              
  Lines        1986     1985       -1     
==========================================
  Hits         1900     1900              
+ Misses         86       85       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit ee3abff into main Mar 5, 2024
6 checks passed
@zxkane zxkane deleted the fix-sessionId branch March 5, 2024 04:02
@zhu-xiaowei
Copy link
Contributor Author

Fixed the issue #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants